Welcome! Log In Create A New Profile

Advanced

[PHP-DEV] str_getcsv

Posted by Steve Hanselman 
Steve Hanselman
[PHP-DEV] str_getcsv
October 20, 2008 10:45PM
Can anybody suggest a reason why this has never moved from main to php_5_2 or php_5_3?

It was added to MAIN in dec '06

Steve



The information contained in this email is intended for the personal and confidential use
of the addressee only. It may also be privileged information. If you are not the intended
recipient then you are hereby notified that you have received this document in error and
that any review, distribution or copying of this document is strictly prohibited. If you have
received this communication in error, please notify Brendata immediately on:

+44 (0)1268 466100, or email '[email protected]'

Brendata (UK) Ltd
Nevendon Hall, Nevendon Road, Basildon, Essex. SS13 1BX UK
Registered Office as above. Registered in England No. 2764339

See our current vacancies at www.brendata.co.uk

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hannes Magnusson
Re: [PHP-DEV] str_getcsv
October 20, 2008 10:50PM
On Mon, Oct 20, 2008 at 22:43, Steve Hanselman <[email protected]> wrote:
> Can anybody suggest a reason why this has never moved from main to php_5_2 or php_5_3?

I did wonder the same months ago, but noone seemed to care, and I had
no use for it myself so I never bothered merging it :)

> The information contained in this email is intended for the personal and confidential use

Are you high?

-Hannes

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Steve Hanselman
RE: [PHP-DEV] str_getcsv
October 20, 2008 11:10PM
If it's not stupid question, what is the main branch for? Presumably the other branches aren't just branched from this at a point in time or we'd have this in there.

High? Nah, just chilled after a glass or two of wine. Can't beat a good corporate disclaimer!

Steve


________________________________

From: Hannes Magnusson [mailto:[email protected]]
Sent: Mon 20/10/2008 9:46
To: Steve Hanselman
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] str_getcsv



On Mon, Oct 20, 2008 at 22:43, Steve Hanselman <[email protected]> wrote:
> Can anybody suggest a reason why this has never moved from main to php_5_2 or php_5_3?

I did wonder the same months ago, but noone seemed to care, and I had
no use for it myself so I never bothered merging it :)

> The information contained in this email is intended for the personal and confidential use

Are you high?

-Hannes

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php




The information contained in this email is intended for the personal and confidential use
of the addressee only. It may also be privileged information. If you are not the intended
recipient then you are hereby notified that you have received this document in error and
that any review, distribution or copying of this document is strictly prohibited. If you have
received this communication in error, please notify Brendata immediately on:

+44 (0)1268 466100, or email '[email protected]'

Brendata (UK) Ltd
Nevendon Hall, Nevendon Road, Basildon, Essex. SS13 1BX UK
Registered Office as above. Registered in England No. 2764339

See our current vacancies at www.brendata.co.uk

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Ilia Alshanetsky
Re: [PHP-DEV] str_getcsv
October 20, 2008 11:10PM
On 20-Oct-08, at 4:46 PM, Hannes Magnusson wrote:

> On Mon, Oct 20, 2008 at 22:43, Steve Hanselman
> <[email protected]> wrote:
>> Can anybody suggest a reason why this has never moved from main to
>> php_5_2 or php_5_3?
>
> I did wonder the same months ago, but noone seemed to care, and I had
> no use for it myself so I never bothered merging it :)

The functionality is rather handy (I think), I would +1 for its
addition to the 5.3 branch.

Ilia Alshanetsky





--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Lukas Kahwe Smith
Re: [PHP-DEV] str_getcsv
October 20, 2008 11:40PM
On 20.10.2008, at 23:07, Ilia Alshanetsky wrote:

>
> On 20-Oct-08, at 4:46 PM, Hannes Magnusson wrote:
>
>> On Mon, Oct 20, 2008 at 22:43, Steve Hanselman
>> <[email protected]> wrote:
>>> Can anybody suggest a reason why this has never moved from main to
>>> php_5_2 or php_5_3?
>>
>> I did wonder the same months ago, but noone seemed to care, and I had
>> no use for it myself so I never bothered merging it :)
>
> The functionality is rather handy (I think), I would +1 for its
> addition to the 5.3 branch.


if someone commits it before alpha3 its fine by me.

regards,
Lukas Kahwe Smith
mls@pooteeweet.org




--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Johannes Schl
RE: [PHP-DEV] str_getcsv
October 21, 2008 01:25AM
On Mon, 2008-10-20 at 22:03 +0100, Steve Hanselman wrote:
> If it's not stupid question, what is the main branch for? Presumably
> the other branches aren't just branched from this at a point in time
> or we'd have this in there.

The "main" branch? PHP_5_X are the "stable" branches, "HEAD" is the
development branch (at least in theory ...) So stuff is added to HEAD
and merged bacxk when it's stable enough and need (and somebody cares)

+1 from me, though...

johannes


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Steve Hanselman
RE: [PHP-DEV] str_getcsv
October 21, 2008 07:35PM
> The "main" branch? PHP_5_X are the "stable" branches, "HEAD" is the
> development branch (at least in theory ...) So stuff is added to HEAD
> and merged bacxk when it's stable enough and need (and somebody cares)
>
> +1 from me, though...
>
> johannes

Now, if we could work the phrase "namespaces" into this somehow we'd probably have this in HEAD within a few days.....

On a serious note, there seem to have been quite a few commits to MAIN over time, so I wonder what else is lurking there that could be useful?

If nobody else is doing this then I'm happy to build a diff, What's involved in getting a commit account for CVS or is it easier to just email a diff set to somebody (in which case, who?)


Steve



The information contained in this email is intended for the personal and confidential use
of the addressee only. It may also be privileged information. If you are not the intended
recipient then you are hereby notified that you have received this document in error and
that any review, distribution or copying of this document is strictly prohibited. If you have
received this communication in error, please notify Brendata immediately on:

+44 (0)1268 466100, or email '[email protected]'

Brendata (UK) Ltd
Nevendon Hall, Nevendon Road, Basildon, Essex. SS13 1BX UK
Registered Office as above. Registered in England No. 2764339

See our current vacancies at www.brendata.co.uk

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Pierre Joye
Re: [PHP-DEV] str_getcsv
October 21, 2008 08:30PM
hi,

On Tue, Oct 21, 2008 at 7:32 PM, Steve Hanselman <[email protected]> wrote:
>> The "main" branch? PHP_5_X are the "stable" branches, "HEAD" is the
>> development branch (at least in theory ...) So stuff is added to HEAD
>> and merged bacxk when it's stable enough and need (and somebody cares)
>>
>> +1 from me, though...
>>
>> johannes
>
> Now, if we could work the phrase "namespaces" into this somehow we'd probably have this in HEAD within a few days.....
>
> On a serious note, there seem to have been quite a few commits to MAIN over time, so I wonder what else is lurking there that could be useful?
>
> If nobody else is doing this then I'm happy to build a diff, What's involved in getting a commit account for CVS or is it easier to just email a diff set to somebody (in which case, who?)

Easiest (and safest) is:
- to create a patch (cvs diff -up)
- open a feature request (a bug :) in bugs.php.net, with a link to the patch
- post it in this thread as well with a ref to the bug #

Doing so will make sure that your patch will not be lost in the archive :)

After having provided a couple of patches, you may consider a CVS
account request.

Thanks for your work!

Cheers,
--
Pierre

http://blog.thepimp.net | http://www.libgd.org

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Felipe Pena
Re: [PHP-DEV] str_getcsv
November 02, 2008 11:45PM
Hello,

2008/10/20 Lukas Kahwe Smith <[email protected]>:
>
> On 20.10.2008, at 23:07, Ilia Alshanetsky wrote:
>
>>
>> On 20-Oct-08, at 4:46 PM, Hannes Magnusson wrote:
>>
>>> On Mon, Oct 20, 2008 at 22:43, Steve Hanselman <[email protected]>
>>> wrote:
>>>>
>>>> Can anybody suggest a reason why this has never moved from main to
>>>> php_5_2 or php_5_3?
>>>
>>> I did wonder the same months ago, but noone seemed to care, and I had
>>> no use for it myself so I never bothered merging it :)
>>
>> The functionality is rather handy (I think), I would +1 for its addition
>> to the 5.3 branch.
>
>
> if someone commits it before alpha3 its fine by me.
>

Done!

I've added a test and it's failing in HEAD though. We need check it,
and to see what's the real behavior expected.

A notable difference between the HEAD and 5.x fgetcsv implementation,
is that in HEAD the delimiter, enclosure and escape can have more than
1 char. Then the following is valid:

// string input[, string delimiter[, string enclosure[, string escape]]]
var_dump(str_getcsv('<>foo++<><>[]<>bar<>', '[]', '<>', '++'));

Should we really accept that?

--
Regards,
Felipe Pena.

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sorry, only registered users may post in this forum.

Click here to login