Welcome! Log In Create A New Profile

Advanced

[PHP-DEV] fix for 61418 breaks win32 build

Posted by Stas Malyshev 
Stas Malyshev
[PHP-DEV] fix for 61418 breaks win32 build
March 23, 2012 06:30AM
Hi!

Commit 714f1ff4b37c5101b3c61ea108a3d415f41e50df is breaking win32 build
and causing bug #61482. I am reverting this commit. Gustavo, please
check the code and see if you can improve the fix so it does not break
win32. The reproduction details are in the bug 61482.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Gustavo Lopes
[PHP-DEV] Re: fix for 61418 breaks win32 build
March 23, 2012 10:40AM
On Fri, 23 Mar 2012 06:26:22 +0100, Stas Malyshev <[email protected]>
wrote:

> Commit 714f1ff4b37c5101b3c61ea108a3d415f41e50df is breaking win32 build
> and causing bug #61482. I am reverting this commit. Gustavo, please
> check the code and see if you can improve the fix so it does not break
> win32. The reproduction details are in the bug 61482.

Actually, Dmitry and I were discussing this issue yesterday on IRC (check
your logs). He too detected the problem and had reverted the fix for bug
#61418.

The fix for bug #61482 may be simple and I will both reinstate my fix for
bug #61418 and correct it, but I'll only be able to test it more
thoroughly during the weekend.

--
Gustavo Lopes

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Stas Malyshev
[PHP-DEV] Re: fix for 61418 breaks win32 build
March 23, 2012 06:20PM
Hi!

> Actually, Dmitry and I were discussing this issue yesterday on IRC (check
> your logs). He too detected the problem and had reverted the fix for bug
> #61418.

Sorry, I don't watch IRC lately.

> The fix for bug #61482 may be simple and I will both reinstate my fix for
> bug #61418 and correct it, but I'll only be able to test it more
> thoroughly during the weekend.

OK, I'll see if my windows test machine works fine with that fix in the
evening.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sorry, only registered users may post in this forum.

Click here to login