[PHP-DEV] full LFS support

Hi.

I would like to know what is the current status of the LFS support for php.

http://bugs.php.net/bug.php?id=27792
http://bugs.php.net/bug.php?id=48886

As far as I can see, there are some patches floating around, but some
of them doesn't work, some of them are incomplete.

As far as I can see, with the latest release(5.3.3) you can't stat or
filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB on
64bit.
Is this true?
From the proposed patches, it seems that there arent that many LOC
which needs to be adjusted to provide a decent LFS support.
Are there any blocker objections or architectural problems, or we just
lack specification or manpower to fix this issue?
If this gets fixed, will this be included into the 5.3 branch, or this
can only be added with the next major version?

Tyrael

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

nobody to care this change? :(

-----邮件原件-----
发件人: tyra3l@gmail.com [mailto:[email protected]] 代表 Ferenc Kovacs
发送时间: 2010年7月30日 22:14
收件人: PHP Internals
主题: [PHP-DEV] full LFS support

Hi.

I would like to know what is the current status of the LFS support for php.

http://bugs.php.net/bug.php?id=27792
http://bugs.php.net/bug.php?id=48886

As far as I can see, there are some patches floating around, but some of them doesn't work, some of them are incomplete.

As far as I can see, with the latest release(5.3.3) you can't stat or filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB on 64bit.
Is this true?
From the proposed patches, it seems that there arent that many LOC which needs to be adjusted to provide a decent LFS support.
Are there any blocker objections or architectural problems, or we just lack specification or manpower to fix this issue?
If this gets fixed, will this be included into the 5.3 branch, or this can only be added with the next major version?

Tyrael


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Maybe this is just lost in the weekend's email swarm.
At least I hope this is the reason for the silence.

Tyrael

On Tue, Aug 3, 2010 at 2:11 PM, 高春辉 <[email protected]> wrote:
> nobody to care this change? :(
>
> -----邮件原件-----
> 发件人: tyra3l@gmail.com [mailto:[email protected]] 代表 Ferenc Kovacs
> 发送时间: 2010年7月30日 22:14
> 收件人: PHP Internals
> 主题: [PHP-DEV] full LFS support
>
> Hi.
>
> I would like to know what is the current status of the LFS support for php.
>
> http://bugs.php.net/bug.php?id=27792
> http://bugs.php.net/bug.php?id=48886
>
> As far as I can see, there are some patches floating around, but some of them doesn't work, some of them are incomplete.
>
> As far as I can see, with the latest release(5.3.3) you can't stat or filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB on 64bit.
> Is this true?
> From the proposed patches, it seems that there arent that many LOC which needs to be adjusted to provide a decent LFS support.
> Are there any blocker objections or architectural problems, or we just lack specification or manpower to fix this issue?
> If this gets fixed, will this be included into the 5.3 branch, or this can only be added with the next major version?
>
> Tyrael
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

$code < $complaints;

On Tue, Aug 3, 2010 at 6:01 AM, Ferenc Kovacs <[email protected]> wrote:
> Maybe this is just lost in the weekend's email swarm.
> At least I hope this is the reason for the silence.
>
> Tyrael
>
> On Tue, Aug 3, 2010 at 2:11 PM, 高春辉 <[email protected]> wrote:
>> nobody to care this change? :(
>>
>> -----邮件原件-----
>> 发件人: tyra3l@gmail.com [mailto:[email protected]] 代表 Ferenc Kovacs
>> 发送时间: 2010年7月30日 22:14
>> 收件人: PHP Internals
>> 主题: [PHP-DEV] full LFS support
>>
>> Hi.
>>
>> I would like to know what is the current status of the LFS support for php.
>>
>> http://bugs.php.net/bug.php?id=27792
>> http://bugs.php.net/bug.php?id=48886
>>
>> As far as I can see, there are some patches floating around, but some of them doesn't work, some of them are incomplete.
>>
>> As far as I can see, with the latest release(5.3.3) you can't stat or filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB on 64bit.
>> Is this true?
>> From the proposed patches, it seems that there arent that many LOC which needs to be adjusted to provide a decent LFS support.
>> Are there any blocker objections or architectural problems, or we just lack specification or manpower to fix this issue?
>> If this gets fixed, will this be included into the 5.3 branch, or this can only be added with the next major version?
>>
>> Tyrael
>>
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Sorry:
$code > $complaints;

2010/8/4 Ronald Chmara <[email protected]>:
> $code < $complaints;
>
> On Tue, Aug 3, 2010 at 6:01 AM, Ferenc Kovacs <[email protected]> wrote:
>> Maybe this is just lost in the weekend's email swarm.
>> At least I hope this is the reason for the silence.
>>
>> Tyrael
>>
>> On Tue, Aug 3, 2010 at 2:11 PM, 高春辉 <[email protected]> wrote:
>>> nobody to care this change? :(
>>>
>>> -----邮件原件-----
>>> 发件人: tyra3l@gmail.com [mailto:[email protected]] 代表 Ferenc Kovacs
>>> 发送时间: 2010年7月30日 22:14
>>> 收件人: PHP Internals
>>> 主题: [PHP-DEV] full LFS support
>>>
>>> Hi.
>>>
>>> I would like to know what is the current status of the LFS support for php.
>>>
>>> http://bugs.php.net/bug.php?id=27792
>>> http://bugs.php.net/bug.php?id=48886
>>>
>>> As far as I can see, there are some patches floating around, but some of them doesn't work, some of them are incomplete.
>>>
>>> As far as I can see, with the latest release(5.3.3) you can't stat or filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB on 64bit.
>>> Is this true?
>>> From the proposed patches, it seems that there arent that many LOC which needs to be adjusted to provide a decent LFS support.
>>> Are there any blocker objections or architectural problems, or we just lack specification or manpower to fix this issue?
>>> If this gets fixed, will this be included into the 5.3 branch, or this can only be added with the next major version?
>>>
>>> Tyrael
>>>
>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>>
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

>
>
> > Hi.
> >
> > I would like to know what is the current status of the LFS support for
> php.
> >
> > http://bugs.php.net/bug.php?id=27792
> > http://bugs.php.net/bug.php?id=48886
> >
> > As far as I can see, there are some patches floating around, but some of
> them doesn't work, some of them are incomplete.
> >
> > As far as I can see, with the latest release(5.3.3) you can't stat or
> filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB on 64bit.
> > Is this true?
> > From the proposed patches, it seems that there arent that many LOC which
> needs to be adjusted to provide a decent LFS support.
> > Are there any blocker objections or architectural problems, or we just
> lack specification or manpower to fix this issue?
> > If this gets fixed, will this be included into the 5.3 branch, or this
> can only be added with the next major version?
> >
> > Tyrael
> >
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>

bump.

Tyrael

On Tue, Aug 17, 2010 at 4:22 PM, Ferenc Kovacs <[email protected]> wrote:
>>
>> > Hi.
>> >
>> > I would like to know what is the current status of the LFS support for
>> > php.
>> >
>> > http://bugs.php.net/bug.php?id=27792
>> > http://bugs.php.net/bug.php?id=48886
>> >
>> > As far as I can see, there are some patches floating around, but some of
>> > them doesn't work, some of them are incomplete.
>> >
>> > As far as I can see, with the latest release(5.3.3) you can't stat or
>> > filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB on 64bit.
>> > Is this true?
>> > From the proposed patches, it seems that there arent that many LOC which
>> > needs to be adjusted to provide a decent LFS support.
>> > Are there any blocker objections or architectural problems, or we just
>> > lack specification or manpower to fix this issue?
>> > If this gets fixed, will this be included into the 5.3 branch, or this
>> > can only be added with the next major version?
>> >
>> > Tyrael
>> >
>> >
>> > --
>> > PHP Internals - PHP Runtime Development Mailing List
>> > To unsubscribe, visit: http://www.php.net/unsub.php
>> >
>> >
>
> bump.
> Tyrael

bump
(hoping that maybe laruence or Felipe takes a look)

Tyrael

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

AFAIK Pierre has some point about Windows part.

2011/9/6 Ferenc Kovacs <[email protected]>:
> On Tue, Aug 17, 2010 at 4:22 PM, Ferenc Kovacs <[email protected]> wrote:
>>>
>>> > Hi.
>>> >
>>> > I would like to know what is the current status of the LFS support for
>>> > php.
>>> >
>>> > http://bugs.php.net/bug.php?id=27792
>>> > http://bugs.php.net/bug.php?id=48886
>>> >
>>> > As far as I can see, there are some patches floating around, but some of
>>> > them doesn't work, some of them are incomplete.
>>> >
>>> > As far as I can see, with the latest release(5.3.3) you can't stat or
>>> > filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB on 64bit.
>>> > Is this true?
>>> > From the proposed patches, it seems that there arent that many LOC which
>>> > needs to be adjusted to provide a decent LFS support.
>>> > Are there any blocker objections or architectural problems, or we just
>>> > lack specification or manpower to fix this issue?
>>> > If this gets fixed, will this be included into the 5.3 branch, or this
>>> > can only be added with the next major version?
>>> >
>>> > Tyrael
>>> >
>>> >
>>> > --
>>> > PHP Internals - PHP Runtime Development Mailing List
>>> > To unsubscribe, visit: http://www.php.net/unsub.php
>>> >
>>> >
>>
>> bump.
>> Tyrael
>
> bump
> (hoping that maybe laruence or Felipe takes a look)
>
> Tyrael
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--
Regards,
Felipe Pena

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

bump.

On Tue, Sep 6, 2011 at 4:22 PM, Felipe Pena <[email protected]> wrote:

> AFAIK Pierre has some point about Windows part.
>
> 2011/9/6 Ferenc Kovacs <[email protected]>:
> > On Tue, Aug 17, 2010 at 4:22 PM, Ferenc Kovacs <[email protected]> wrote:
> >>>
> >>> > Hi.
> >>> >
> >>> > I would like to know what is the current status of the LFS support
> for
> >>> > php.
> >>> >
> >>> > http://bugs.php.net/bug.php?id=27792
> >>> > http://bugs.php.net/bug.php?id=48886
> >>> >
> >>> > As far as I can see, there are some patches floating around, but
> some of
> >>> > them doesn't work, some of them are incomplete.
> >>> >
> >>> > As far as I can see, with the latest release(5.3.3) you can't stat or
> >>> > filesize a file where the size is >= 2GiB on 32bit OS, and >= 4GiB
> on 64bit.
> >>> > Is this true?
> >>> > From the proposed patches, it seems that there arent that many LOC
> which
> >>> > needs to be adjusted to provide a decent LFS support.
> >>> > Are there any blocker objections or architectural problems, or we
> just
> >>> > lack specification or manpower to fix this issue?
> >>> > If this gets fixed, will this be included into the 5.3 branch, or
> this
> >>> > can only be added with the next major version?
> >>> >
> >>> > Tyrael
> >>> >
> >>> >
> >>> > --
> >>> > PHP Internals - PHP Runtime Development Mailing List
> >>> > To unsubscribe, visit: http://www.php.net/unsub.php
> >>> >
> >>> >
> >>
> >> bump.
> >> Tyrael
> >
> > bump
> > (hoping that maybe laruence or Felipe takes a look)
> >
> > Tyrael
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>
>
>
> --
> Regards,
> Felipe Pena
>

On Sat, 02 Jun 2012 18:20:43 +0200, Ferenc Kovacs <[email protected]> wrote:

>>>>>> I would like to know what is the current status of the LFS support
>>>>>> for php.
>>>>>>
>>>>>> http://bugs.php.net/bug.php?id=27792
>>>>>> http://bugs.php.net/bug.php?id=48886
>>>>>>[...]
>>>>>>If this gets fixed, will this be included into the 5.3 branch, or
>>>>>> this can only be added with the next major version?

This most likely would be doable only in the next version as it requires
changing the signatures of extension API functions.

I suggest that you make a pull request *with some tests* (you can add a
function to the debug build to create a large sparse file). I'll offer to
review it then.

--
Gustavo Lopes

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

On Sun, Jun 3, 2012 at 1:55 PM, Gustavo Lopes <[email protected]>wrote:

> On Sat, 02 Jun 2012 18:20:43 +0200, Ferenc Kovacs <[email protected]> wrote:
>
> I would like to know what is the current status of the LFS support
>>>>>>> for php.
>>>>>>>
>>>>>>> http://bugs.php.net/bug.php?**id=27792http://bugs.php.net/bug.php?id=27792
>>>>>>> http://bugs.php.net/bug.php?**id=48886http://bugs.php.net/bug.php?id=48886
>>>>>>> [...]
>>>>>>>
>>>>>>> If this gets fixed, will this be included into the 5.3 branch, or
>>>>>>> this can only be added with the next major version?
>>>>>>>
>>>>>>
> This most likely would be doable only in the next version as it requires
> changing the signatures of extension API functions.
>
> I suggest that you make a pull request *with some tests* (you can add a
> function to the debug build to create a large sparse file). I'll offer to
> review it then.
>
>
Hi,

Don't forget that I started this thread back in 2010, targeting 5.3 was
possible (albeit highly unlikely) back then.
I'm aware that this can only introduced in the next major (if we stick to
the release process rfc) php version.

Tyrael

On Sun, Jun 3, 2012 at 2:04 PM, Ferenc Kovacs <[email protected]> wrote:

>
>
> On Sun, Jun 3, 2012 at 1:55 PM, Gustavo Lopes <[email protected]>wrote:
>
>> On Sat, 02 Jun 2012 18:20:43 +0200, Ferenc Kovacs <[email protected]> wrote:
>>
>> I would like to know what is the current status of the LFS support
>>>>>>>> for php.
>>>>>>>>
>>>>>>>> http://bugs.php.net/bug.php?**id=27792http://bugs.php.net/bug.php?id=27792
>>>>>>>> http://bugs.php.net/bug.php?**id=48886http://bugs.php.net/bug.php?id=48886
>>>>>>>> [...]
>>>>>>>>
>>>>>>>> If this gets fixed, will this be included into the 5.3 branch, or
>>>>>>>> this can only be added with the next major version?
>>>>>>>>
>>>>>>>
>> This most likely would be doable only in the next version as it requires
>> changing the signatures of extension API functions.
>>
>> I suggest that you make a pull request *with some tests* (you can add a
>> function to the debug build to create a large sparse file). I'll offer to
>> review it then.
>>
>>
> Hi,
>
> Don't forget that I started this thread back in 2010, targeting 5.3 was
> possible (albeit highly unlikely) back then.
> I'm aware that this can only introduced in the next major (if we stick to
> the release process rfc) php version.
>
>
my bad, 5.3.0 was out already when I opened the thread, so that was a bad
assumption on my part back then.

Tyrael

hi,

On Sun, Jun 3, 2012 at 1:55 PM, Gustavo Lopes <[email protected]> wrote:

> This most likely would be doable only in the next version as it requires
> changing the signatures of extension API functions.
>
> I suggest that you make a pull request *with some tests* (you can add a
> function to the debug build to create a large sparse file). I'll offer to
> review it then.

There are other considerations to take care of besides adding simple
LFS support (with limited needs out there). The magic with double and
co is simply not clean and should be done with real 64bit or large
integer support, or it will just be yet another ugly implementation in
php.

Cheers,
--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

On Mon, 4 Jun 2012 09:32:51 +0200, Pierre Joye wrote:
> On Sun, Jun 3, 2012 at 1:55 PM, Gustavo Lopes
> <[email protected]> wrote:
>
>> This most likely would be doable only in the next version as it
>> requires
>> changing the signatures of extension API functions.
>>
>> I suggest that you make a pull request *with some tests* (you can
>> add a
>> function to the debug build to create a large sparse file). I'll
>> offer to
>> review it then.
>
> There are other considerations to take care of besides adding simple
> LFS support (with limited needs out there). The magic with double and
> co is simply not clean and should be done with real 64bit or large
> integer support, or it will just be yet another ugly implementation
> in
> php.
>

I should tend to agree, but in any case it shouldn't stop us from
fixing the streams C API to use the correct types. As a bonus, we'll
have LFS support in compilers with 64-bit longs.

--
Gustavo Lopes

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

On Mon, Jun 4, 2012 at 9:50 AM, Gustavo Lopes <[email protected]> wrote:

> I should tend to agree, but in any case it shouldn't stop us from fixing the
> streams C API to use the correct types. As a bonus, we'll have LFS support
> in compilers with 64-bit longs.

The correct types usage is a very old todo and should be fixed.
However it can be done only in a major version as it will drastically
affect many extensions. Even if it is mostly internals changes. That's
something I like to begin with this summer, let try to sync us and see
how we can get that done in a reasonable time frame :)

Cheers,
--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php