Welcome! Log In Create A New Profile

Advanced

Re: [PHP-DEV] Adding pecl/http to core

Posted by Johannes Schl 
Johannes Schl
Re: [PHP-DEV] Adding pecl/http to core
October 27, 2008 08:00PM
On Mon, 2008-09-22 at 20:17 +0200, Michael Wallner wrote:
> I wonder what the general opinion is on adding pecl/http to the main PHP
> distribution? Many people have poked me in the past, so I guessed it's
> time to ask me and you that question once for all.

I didn't took a deeper look at it yet, just some doc reading. One thing
I found was that it's using tons of ini settings. Having ini setting
means that an admin might break apps without really knowing.

I think it's fine to have settings for limitations on pconnects, but
stuff like http.request.methods.allowed or http.only_exceptions should
imo be set as object properties (or similar), not globally using ini
settings.

johannes


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Cristian Rodríguez
Re: [PHP-DEV] Adding pecl/http to core
October 28, 2008 02:05AM
Johannes Schlüter escribió:
>or http.only_exceptions should
> imo be set as object properties (or similar), not globally using ini
> settings.

Or just throw only exceptions and no ini setting at all.



--
"A computer is like an Old Testament god, with a lot of rules and no
mercy. "

Cristian Rodríguez R.
Platform/OpenSUSE - Core Services
SUSE LINUX Products GmbH
Research & Development
http://www.opensuse.org/
Attachments:
open | download - signature.asc (267 bytes)
open | download - signature.asc (267 bytes)
Lars Strojny
Re: [PHP-DEV] Adding pecl/http to core
October 28, 2008 12:50PM
Hi Johannes,

Am Montag, den 27.10.2008, 19:59 +0100 schrieb Johannes Schlüter:
[...]
> I think it's fine to have settings for limitations on pconnects, but
> stuff like http.request.methods.allowed or http.only_exceptions should
> imo be set as object properties (or similar), not globally using ini
> settings.

I totally agree, reasons like that and others like Class::singleton()
instead of getInstance() (which seems more common in the PHP world) is
the reason I would like to do a proper API review, before promoting it
to core.

cu, Lars
Attachments:
open | download - signature.asc (854 bytes)
Stan Vassilev | FM
Re: [PHP-DEV] Adding pecl/http to core
October 28, 2008 01:35PM
I've not seen plenty of "Class::singleton()" myself, getInstance is an
accepted standard in all languages, including the PHP code I wrote, and I've
had experience with.

Regards, Stan Vassilev



--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Lars Strojny
Re: [PHP-DEV] Adding pecl/http to core
October 28, 2008 02:55PM
Hi Stan,

Am Dienstag, den 28.10.2008, 14:33 +0200 schrieb Stan Vassilev | FM:
[...]
> I've not seen plenty of "Class::singleton()" myself, getInstance is an
> accepted standard in all languages, including the PHP code I wrote,
> and I've had experience with.

That's my point, yes. pecl_http uses ::singleton() instead of
getInstance().

cu, Lars
--
Jabber: lars@strojny.net
Weblog: http://usrportage.de
Attachments:
open | download - signature.asc (854 bytes)
Michael Wallner
Re: [PHP-DEV] Adding pecl/http to core
October 28, 2008 03:45PM
Johannes Schl
Michael Wallner
Re: [PHP-DEV] Adding pecl/http to core
October 28, 2008 03:50PM
Lars Strojny wrote:
>> I've not seen plenty of "Class::singleton()" myself, getInstance is an
>> accepted standard in all languages, including the PHP code I wrote,
>> and I've had experience with.
>
> That's my point, yes. pecl_http uses ::singleton() instead of
> getInstance().

Well, sure--that depends. PEAR for example defined ::singleton()
as the standard name and most of the code I've dealt with at that
time used ::singleton() either. I guess this is merely a matter
of taste, respectively what's PHP going to use in the future.

Regards,
Mike

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sorry, only registered users may post in this forum.

Click here to login