Welcome! Log In Create A New Profile

Advanced

[PHP-DEV] ZEND_ACC_* flags

Posted by Dmitry Stogov 
Dmitry Stogov
[PHP-DEV] ZEND_ACC_* flags
July 25, 2018 05:10PM
Hi,


I tried to fix ZEND_ACC_* flags mess.


https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1


The patch specifies flags meaning, and reorder them according to meaning and frequency of usage (this allows generation of shorter instructions on x86).

Unfortunately, the patch breaks few reflection based tests that relay on binary modifiers values.


Do you think, it it's OK to commit thin into 7.3 or better to wait for branching?


Thanks. Dmitry.
Marco Pivetta
Re: [PHP-DEV] ZEND_ACC_* flags
July 25, 2018 08:30PM
This can potentially break some cached flags somewhere, and is a BC break:
any rationale behind the change?

On Wed, 25 Jul 2018, 17:01 Dmitry Stogov, <[email protected]> wrote:

> Hi,
>
>
> I tried to fix ZEND_ACC_* flags mess.
>
>
> https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1
>
>
> The patch specifies flags meaning, and reorder them according to meaning
> and frequency of usage (this allows generation of shorter instructions on
> x86).
>
> Unfortunately, the patch breaks few reflection based tests that relay on
> binary modifiers values.
>
>
> Do you think, it it's OK to commit thin into 7.3 or better to wait for
> branching?
>
>
> Thanks. Dmitry.
>
Sara Golemon
Re: [PHP-DEV] ZEND_ACC_* flags
July 26, 2018 12:30AM
On Wed, Jul 25, 2018 at 11:01 AM, Dmitry Stogov <[email protected]> wrote:
>
> I tried to fix ZEND_ACC_* flags mess.
>
> https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1
>
>
> The patch specifies flags meaning, and reorder them according to meaning and frequency of usage (this allows generation of shorter instructions on x86).
> Unfortunately, the patch breaks few reflection based tests that relay on binary modifiers values.
>
Documentation part: LOVE
Sorry, only registered users may post in this forum.

Click here to login