Anatol Belski
[PHP-DEV] [RFC] PCRE2 migration
October 16, 2017 10:20AM
Hi,

I would like hereby to put the RFC about the PCRE2 migration for the
core https://wiki.php.net/rfc/pcre2-migration under discussion. A basic
port is available here https://github.com/php/php-src/pull/2857 for a
review.

Regards

Anatol
Anatol Belski
Re: [PHP-DEV] [RFC] PCRE2 migration
October 23, 2017 07:40AM
Hi,

On 10/16/2017 10:17 AM, Anatol Belski wrote:
> Hi,
>
> I would like hereby to put the RFC about the PCRE2 migration for the
> core https://wiki.php.net/rfc/pcre2-migration under discussion. A basic
> port is available here https://github.com/php/php-src/pull/2857 for a
> review.
>

poke on this :)

Regards

Anatol
Christoph M. Becker
[PHP-DEV] Re: [RFC] PCRE2 migration
October 23, 2017 04:30PM
On 16.10.2017 at 10:17, Anatol Belski wrote:

> I would like hereby to put the RFC about the PCRE2 migration for the
> core https://wiki.php.net/rfc/pcre2-migration under discussion. A basic
> port is available here https://github.com/php/php-src/pull/2857 for a
> review.

Thanks, Anatol, for working on a PCRE2 compatible ext/pcre!

In my opinion, the only real issue is that the internal API would change
(the few userland affecting changes appear to be acceptable). I can't
assess how many extensions actually use the public API of ext/pcre, but
this might be an issue regarding the adoption of PHP 7.3.

This said, I'm presently +0.9 on accepting the RFC.

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Anatol Belski
[PHP-DEV] RE: [RFC] PCRE2 migration
October 23, 2017 10:20PM
Hi Christoph,

> -----Original Message-----
> From: Christoph M. Becker [mailto:[email protected]]
> Sent: Monday, October 23, 2017 4:24 PM
> To: Anatol Belski <[email protected]>; internals@lists.php.net
> Subject: Re: [RFC] PCRE2 migration
>
> In my opinion, the only real issue is that the internal API would change (the few
> userland affecting changes appear to be acceptable). I can't assess how many
> extensions actually use the public API of ext/pcre, but this might be an issue
> regarding the adoption of PHP 7.3.
>
Some exts use PCRE or the PHP API, of course. From what I've seen so far

- The migration is easy, despite the PCRE2 API is somewhat different. If asked, I could help patching any code for PCRE2 support.
- there's time to rework the API as in the patch, some points can be changed significantly
- From what I could tell, the ratio of PECL exts using PCRE is low. In fact, I can't remember any, OFC there are be some.

> This said, I'm presently +0.9 on accepting the RFC.
>
PCRE2 implements new features and fixes issues, while the legacy version only gets backports which are not optimal. At the time after two years PCRE2 release and the situation with PCRE support, switching seems a thing to me. The existing features are not broken, better Unicode support and improvements in functionality and memory handling speak for that.

Regards

Anatol
Jakub Zelenka
Re: [PHP-DEV] [RFC] PCRE2 migration
October 23, 2017 10:50PM
Hey

On Mon, Oct 16, 2017 at 9:17 AM, Anatol Belski <[email protected]> wrote:

> Hi,
>
> I would like hereby to put the RFC about the PCRE2 migration for the
> core https://wiki.php.net/rfc/pcre2-migration under discussion. A basic
> port is available here https://github.com/php/php-src/pull/2857 for a
> review.
>
>
Sorry if that's a stupid question and I'm missing something important but
why do we need to still bundle PCRE2?

Cheers

Jakub
Anatol Belski
RE: [PHP-DEV] [RFC] PCRE2 migration
October 23, 2017 11:10PM
Hi Jakub,

> -----Original Message-----
> From: jakub.php@gmail.com [mailto:[email protected]] On Behalf Of Jakub
> Zelenka
> Sent: Monday, October 23, 2017 10:43 PM
> To: Anatol Belski <[email protected]>
> Cc: internals@lists.php.net
> Subject: Re: [PHP-DEV] [RFC] PCRE2 migration
>
> Hey
>
>
> On Mon, Oct 16, 2017 at 9:17 AM, Anatol Belski <[email protected]
> <mailto:[email protected]> > wrote:
>
>
> Hi,
>
> I would like hereby to put the RFC about the PCRE2 migration for the
> core https://wiki.php.net/rfc/pcre2-migration
> https://wiki.php.net/rfc/pcre2-migration under discussion. A basic
> port is available here https://github.com/php/php-src/pull/2857
> https://github.com/php/php-src/pull/2857 for a
> review.
>
>
>
>
> Sorry if that's a stupid question and I'm missing something important but why do
> we need to still bundle PCRE2?
>
I ask such questions just for the fun of it all the time, that makes sense to my character
Jakub Zelenka
Re: [PHP-DEV] [RFC] PCRE2 migration
October 24, 2017 04:00PM
On Mon, Oct 23, 2017 at 10:07 PM, Anatol Belski <[email protected]> wrote:

> Hi Jakub,
>
> > -----Original Message-----
> > From: jakub.php@gmail.com [mailto:[email protected]] On Behalf Of
> Jakub
> > Zelenka
> > Sent: Monday, October 23, 2017 10:43 PM
> > To: Anatol Belski <[email protected]>
> > Cc: internals@lists.php.net
> > Subject: Re: [PHP-DEV] [RFC] PCRE2 migration
> >
> > Hey
> >
> >
> > On Mon, Oct 16, 2017 at 9:17 AM, Anatol Belski <[email protected]
> > <mailto:[email protected]> > wrote:
> >
> >
> > Hi,
> >
> > I would like hereby to put the RFC about the PCRE2 migration for
> the
> > core https://wiki.php.net/rfc/pcre2-migration
> > https://wiki.php.net/rfc/pcre2-migration under discussion. A basic
> > port is available here https://github.com/php/php-src/pull/2857
> > https://github.com/php/php-src/pull/2857 for a
> > review.
> >
> >
> >
> >
> > Sorry if that's a stupid question and I'm missing something important
> but why do
> > we need to still bundle PCRE2?
> >
> I ask such questions just for the fun of it all the time, that makes sense
> to my character
Anatol Belski
RE: [PHP-DEV] [RFC] PCRE2 migration
October 24, 2017 08:50PM
Hi Jakub,

> -----Original Message-----
> From: jakub.php@gmail.com [mailto:[email protected]] On Behalf Of Jakub
> Zelenka
> Sent: Tuesday, October 24, 2017 3:54 PM
> To: Anatol Belski <[email protected]>
> Cc: internals@lists.php.net
> Subject: Re: [PHP-DEV] [RFC] PCRE2 migration
>
>
>
> On Mon, Oct 23, 2017 at 10:07 PM, Anatol Belski <[email protected]
> <mailto:[email protected]> > wrote:
>
>
> Hi Jakub,
>
> > -----Original Message-----
> > From: jakub.php@gmail.com <mailto:[email protected]>
> [mailto:[email protected] <mailto:[email protected]> ] On Behalf Of
> Jakub
> > Zelenka
> > Sent: Monday, October 23, 2017 10:43 PM
> > To: Anatol Belski <[email protected] <mailto:[email protected]> >
> > Cc: internals@lists.php.net <mailto:[email protected]>
> > Subject: Re: [PHP-DEV] [RFC] PCRE2 migration
> >
> > Hey
> >
> >
> > On Mon, Oct 16, 2017 at 9:17 AM, Anatol Belski <[email protected]
> <mailto:[email protected]>
> > <mailto:[email protected] <mailto:[email protected]> > > wrote:
> >
> >
> > Hi,
> >
> > I would like hereby to put the RFC about the PCRE2 migration for
> the
> > core https://wiki.php.net/rfc/pcre2-migration
> https://wiki.php.net/rfc/pcre2-migration
> > <https://wiki.php.net/rfc/pcre2-migration
> https://wiki.php.net/rfc/pcre2-migration > under discussion. A basic
> > port is available here https://github.com/php/php-src/pull/2857
> https://github.com/php/php-src/pull/2857
> > <https://github.com/php/php-src/pull/2857
> https://github.com/php/php-src/pull/2857 > for a
> > review.
> >
> >
> >
> >
> > Sorry if that's a stupid question and I'm missing something important
> but why do
> > we need to still bundle PCRE2?
> >
> I ask such questions just for the fun of it all the time, that makes sense
> to my character
Christoph M. Becker
[PHP-DEV] Re: [RFC] PCRE2 migration
October 25, 2017 06:00PM
Hi Anatol!

On 23.10.2017 at 22:12, Anatol Belski wrote:

>> -----Original Message-----
>> From: Christoph M. Becker [mailto:[email protected]]
>> Sent: Monday, October 23, 2017 4:24 PM
>> To: Anatol Belski <[email protected]>; internals@lists.php.net
>> Subject: Re: [RFC] PCRE2 migration
>>
>> In my opinion, the only real issue is that the internal API would change (the few
>> userland affecting changes appear to be acceptable). I can't assess how many
>> extensions actually use the public API of ext/pcre, but this might be an issue
>> regarding the adoption of PHP 7.3.
>
> Some exts use PCRE or the PHP API, of course. From what I've seen so far
>
> - The migration is easy, despite the PCRE2 API is somewhat different. If asked, I could help patching any code for PCRE2 support.
> - there's time to rework the API as in the patch, some points can be changed significantly
> - From what I could tell, the ratio of PECL exts using PCRE is low. In fact, I can't remember any, OFC there are be some.

Well, that sounds good. :) And yes, I'm aware that upgrading to PCRE2
is actually long overdue, so +1 from me.

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sorry, only registered users may post in this forum.

Click here to login