Welcome! Log In Create A New Profile

Advanced

[PHP-DEV] Re: [PHP-CVS] com php-src: Add line numbers to Opcache's zend_dump_op() debug output: ext/opcache/Optimizer/zend_dump.c ext/opcache/tests/opt/dce_001.phpt ext/opcache/tests/opt/dce_002.phpt ext/opcache/tests/opt/dce_003.phpt ext/opcache/tests/op

Posted by Rasmus Lerdorf 
Sara/Remi do you mind if I merge this into 7.2? This affects opcache debug
output only and I want to start playing with some DCE reporting from Phan.
Having the original line numbers available will make that more effective.

On Fri, Oct 6, 2017 at 11:03 AM, Rasmus Lerdorf <[email protected]> wrote:

> Commit: 9fe6b29356923c23fadf610a9fa421cff8b06d6d
> Author: Rasmus Lerdorf <[email protected]> Fri, 6 Oct 2017
> 11:03:07 -0300
> Parents: 45ee78e0403b973e7df4cbcd2ce0c485efa590ea
> Branches: master
>
> Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=
> 9fe6b29356923c23fadf610a9fa421cff8b06d6d
>
> Log:
> Add line numbers to Opcache's zend_dump_op() debug output
>
> Changed paths:
> M ext/opcache/Optimizer/zend_dump.c
> M ext/opcache/tests/opt/dce_001.phpt
> M ext/opcache/tests/opt/dce_002.phpt
> M ext/opcache/tests/opt/dce_003.phpt
> M ext/opcache/tests/opt/dce_004.phpt
> M ext/opcache/tests/opt/dce_005.phpt
> M ext/opcache/tests/opt/dce_006.phpt
> M ext/opcache/tests/opt/dce_007.phpt
> M ext/opcache/tests/opt/dce_008.phpt
> M ext/opcache/tests/opt/sccp_001.phpt
> M ext/opcache/tests/opt/sccp_002.phpt
> M ext/opcache/tests/opt/sccp_003.phpt
> M ext/opcache/tests/opt/sccp_004.phpt
> M ext/opcache/tests/opt/sccp_005.phpt
> M ext/opcache/tests/opt/sccp_006.phpt
> M ext/opcache/tests/opt/sccp_007.phpt
> M ext/opcache/tests/opt/sccp_008.phpt
> M ext/opcache/tests/opt/sccp_009.phpt
> M ext/opcache/tests/opt/sccp_010.phpt
> M ext/opcache/tests/opt/sccp_011.phpt
> M ext/opcache/tests/opt/sccp_012.phpt
> M ext/opcache/tests/opt/sccp_016.phpt
> M ext/opcache/tests/opt/sccp_017.phpt
> M ext/opcache/tests/opt/sccp_019.phpt
> M ext/opcache/tests/opt/sccp_022.phpt
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
On Fri, Oct 6, 2017 at 10:18 AM, Rasmus Lerdorf <[email protected]> wrote:
> Sara/Remi do you mind if I merge this into 7.2? This affects opcache debug
> output only and I want to start playing with some DCE reporting from Phan.
> Having the original line numbers available will make that more effective.
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=9fe6b29356923c23fadf610a9fa421cff8b06d6d
>
Literally two low-risk lines of actual change to a debug-only path?
Zero objections from me.

-Sara

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
On Fri, Oct 6, 2017 at 12:04 PM, Sara Golemon <[email protected]> wrote:

> On Fri, Oct 6, 2017 at 10:18 AM, Rasmus Lerdorf <[email protected]>
> wrote:
> > Sara/Remi do you mind if I merge this into 7.2? This affects opcache
> debug
> > output only and I want to start playing with some DCE reporting from
> Phan.
> > Having the original line numbers available will make that more effective.
> >
> > http://git.php.net/?p=php-src.git;a=commitdiff;h=
> 9fe6b29356923c23fadf610a9fa421cff8b06d6d
> >
> Literally two low-risk lines of actual change to a debug-only path?
> Zero objections from me.


Correct, the zend_dump_op() call I tweaked is only ever called if
opcache.debug_level is set. The bulk of the patch is to add the resulting
line numbers to the tests that use this debug info to verify the output
from the optimizer.

-Rasmus
Le 06/10/2017 à 21:59, Rasmus Lerdorf a écrit :
> On Fri, Oct 6, 2017 at 12:04 PM, Sara Golemon <[email protected]> wrote:
>
>> On Fri, Oct 6, 2017 at 10:18 AM, Rasmus Lerdorf <[email protected]>
>> wrote:
>>> Sara/Remi do you mind if I merge this into 7.2? This affects opcache
>> debug
>>> output only and I want to start playing with some DCE reporting from
>> Phan.
>>> Having the original line numbers available will make that more effective.
>>>
>>> http://git.php.net/?p=php-src.git;a=commitdiff;h=
>> 9fe6b29356923c23fadf610a9fa421cff8b06d6d
>>>
>> Literally two low-risk lines of actual change to a debug-only path?
>> Zero objections from me.
>
>
> Correct, the zend_dump_op() call I tweaked is only ever called if
> opcache.debug_level is set. The bulk of the patch is to add the resulting
> line numbers to the tests that use this debug info to verify the output
> from the optimizer.
>
> -Rasmus
>

I'm late, as already applied in 7.2, but of course, this is ok for me.


Remi


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sorry, only registered users may post in this forum.

Click here to login