Welcome! Log In Create A New Profile

Advanced

[PHP-DEV] Expose gmp_ce and friends

Posted by Sara Golemon 
Sara Golemon
[PHP-DEV] Expose gmp_ce and friends
October 02, 2017 11:40PM
Stas specifically, but also others:

Any objections if I apply
https://github.com/php/php-src/compare/master...sgolemon:gmp.export to
make consuming GMP objects from third-party extensions easier?

-Sara

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Kalle Sommer Nielsen
Re: [PHP-DEV] Expose gmp_ce and friends
October 04, 2017 11:40PM
Hi Sara

2017-10-02 23:33 GMT+02:00 Sara Golemon <[email protected]>:
> Stas specifically, but also others:
>
> Any objections if I apply
> https://github.com/php/php-src/compare/master...sgolemon:gmp.export to
> make consuming GMP objects from third-party extensions easier?

+1, only note I have is that with the change to config.m4, a relevant
one should maybe also follow for phpize on Windows for config.w32


--
regards,

Kalle Sommer Nielsen
kalle@php.net

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Johannes Schlüter
Re: [PHP-DEV] Expose gmp_ce and friends
October 05, 2017 03:00PM
On Mo, 2017-10-02 at 17:33 -0400, Sara Golemon wrote:
> Stas specifically, but also others:
>
> Any objections if I apply
> https://github.com/php/php-src/compare/master...sgolemon:gmp.export
> to
> make consuming GMP objects from third-party extensions easier?
>
> -Sara

I would prefer not exporting the php_gmp.h, but a gmp.h (or similar)
and let php_gmp.h there for main/builtin_functions.c only. If a
consumer wants access to the module_entry they can query EG(modules)
and other declarations in there should be "private".

johannes

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sara Golemon
Re: [PHP-DEV] Expose gmp_ce and friends
October 05, 2017 05:30PM
On Thu, Oct 5, 2017 at 8:50 AM, Johannes Schlüter
<[email protected]> wrote:
> I would prefer not exporting the php_gmp.h, but a gmp.h (or similar)
> and let php_gmp.h there for main/builtin_functions.c only. If a
> consumer wants access to the module_entry they can query EG(modules)
> and other declarations in there should be "private".
>
Yeah, I shouldn't be lazy. I should do things right.

On Wed, Oct 4, 2017 at 5:32 PM, Kalle Sommer Nielsen <[email protected]> wrote:
> +1, only note I have is that with the change to config.m4, a relevant
> one should maybe also follow for phpize on Windows for config.w32
>
Ugh, windows... is that still a thing?

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sorry, only registered users may post in this forum.

Click here to login