Welcome! Log In Create A New Profile

Advanced

[PHP-DEV] Merging LDAP controls support

Posted by Côme Chilliet 
Côme Chilliet
[PHP-DEV] Merging LDAP controls support
September 12, 2017 05:50PM
Hello,

I’m getting close to have something I can merge in master for my PR adding support for LDAP controls: https://github.com/php/php-src/pull/2640

In this case am I suppose to squash the changes in a single commit? This was suggested to me for a previous PR but there is so much changes here I feel we should keep the history.

If some of you can pull my branch and launch the tests from ext/ldap it would help. You’ll need an LDAP server and to fill the env vars from ext/ldap/tests/connect.inc.

Côme

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sorry, only registered users may post in this forum.

Click here to login