Welcome! Log In Create A New Profile

Advanced

[PHP-DEV] Small mistake on wiki

Posted by Anonymous User 
Anonymous User
[PHP-DEV] Small mistake on wiki
January 12, 2017 09:50AM
Hi,

The page https://wiki.php.net/phpng-upgrading#call_frame_changes_zend_execute_data
says:

> zend_execute_data.num_args - number of arguments passed to the function (this is a new field)

However, there's no such field in zend_execute_data structure:
https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L430
it's in zend_function: https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L414

Probably this line should be removed from the wiki page.

Thanks

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Kalle Sommer Nielsen
Re: [PHP-DEV] Small mistake on wiki
January 12, 2017 10:10AM
Hi

2017-01-12 9:38 GMT+01:00 <[email protected]>:
> Hi,
>
> The page https://wiki.php.net/phpng-upgrading#call_frame_changes_zend_execute_data
> says:
>
>> zend_execute_data.num_args - number of arguments passed to the function (this is a new field)
>
> However, there's no such field in zend_execute_data structure:
> https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L430
> it's in zend_function: https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L414
>
> Probably this line should be removed from the wiki page.

True, but PHP 5 is still widely available and 5.6 is still supported.
Some companies support their extensions for PHP even longer than we
support that specific branch, so leaving such information, despite we
have only a tiny bit internals docs laying around may not be such a
bad idea.

--
regards,

Kalle Sommer Nielsen
kalle@php.net

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Joe Watkins
Re: [PHP-DEV] Small mistake on wiki
January 12, 2017 10:30AM
Morning,

Other stuff that has been removed has strike through it, that would seem
approrpiate ?

Cheers
Joe

On Thu, Jan 12, 2017 at 8:59 AM, Kalle Sommer Nielsen <[email protected]> wrote:

> Hi
>
> 2017-01-12 9:38 GMT+01:00 <[email protected]>:
> > Hi,
> >
> > The page https://wiki.php.net/phpng-upgrading#call_frame_changes_
> zend_execute_data
> > says:
> >
> >> zend_execute_data.num_args - number of arguments passed to the function
> (this is a new field)
> >
> > However, there's no such field in zend_execute_data structure:
> > https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L430
> > it's in zend_function: https://github.com/php/php-
> src/blob/PHP-7.0.15/Zend/zend_compile.h#L414
> >
> > Probably this line should be removed from the wiki page.
>
> True, but PHP 5 is still widely available and 5.6 is still supported.
> Some companies support their extensions for PHP even longer than we
> support that specific branch, so leaving such information, despite we
> have only a tiny bit internals docs laying around may not be such a
> bad idea.
>
> --
> regards,
>
> Kalle Sommer Nielsen
> kalle@php.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Kalle Sommer Nielsen
Re: [PHP-DEV] Small mistake on wiki
January 12, 2017 10:40AM
2017-01-12 10:28 GMT+01:00 Joe Watkins <[email protected]>:
> Morning,
>
> Other stuff that has been removed has strike through it, that would seem
> approrpiate ?

Seems like a good idea, then we can indicate its not suggested to use
anymore and we still keep the information readable :)


--
regards,

Kalle Sommer Nielsen
kalle@php.net

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Anonymous User
Re: [PHP-DEV] Small mistake on wiki
January 12, 2017 11:30AM
12.01.2017, 11:59, "Kalle Sommer Nielsen" <[email protected]>:
> Hi
>
> 2017-01-12 9:38 GMT+01:00 <[email protected]>:
>>  Hi,
>>
>>  The page https://wiki.php.net/phpng-upgrading#call_frame_changes_zend_execute_data
>>  says:
>>
>>>  zend_execute_data.num_args - number of arguments passed to the function (this is a new field)
>>
>>  However, there's no such field in zend_execute_data structure:
>>  https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L430
>>  it's in zend_function: https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L414
>>
>>  Probably this line should be removed from the wiki page.
>
> True, but PHP 5 is still widely available and 5.6 is still supported.
> Some companies support their extensions for PHP even longer than we
> support that specific branch, so leaving such information, despite we
> have only a tiny bit internals docs laying around may not be such a
> bad idea.

This wiki page is specifically for PHP 7 migration, it has nothing to do with PHP5

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Sorry, only registered users may post in this forum.

Click here to login