Welcome! Log In Create A New Profile

Advanced

[PHP-DEV] [RFC][VOTE] array_change_keys

Posted by Colin O'Dell 
Colin O'Dell
[PHP-DEV] [RFC][VOTE] array_change_keys
January 08, 2017 03:30PM
Greetings all,

It's been a while since we introduced the array_change_keys RFC
https://wiki.php.net/rfc/array_change_keys. During the discussion period
there was a healthy mix of interest and critique. It seems all the major
discussion points were covered, so I'd like to put this RFC to a vote to
determine its fate.

Therefore, voting is now open on the array_change_keys RFC:
https://wiki.php.net/rfc/array_change_keys Voting will close 2017-01-23 at
23:59:59 UTC.

Mailing list discussion thread:
https://marc.info/?l=php-internals&m=146452769326964&w=2

Reddit discussion thread:
https://www.reddit.com/r/PHP/comments/4ll1hg/rfc_array_change_keys/

The implementation is also on 3v4l.org should you wish to test it out.

Regards,

Colin O'Dell
Marco Pivetta
Re: [PHP-DEV] [RFC][VOTE] array_change_keys
January 08, 2017 03:50PM
Hi Colin,

Voting NO for the following reasons:

* Can be a userland function/library, unless there are huge performance
benefits that justify it being in core
* Doesn't work with `iterable`
* New warnings. No, please, we want `Throwable`: warnings are terrible
* Semantics for merging duplicate keys should be part of the function
name, or a parameter (the former being better, having a strict version that
fails, and a merging version that overwrites)
* I totally forgot that I benchmarked this before :-\
https://github.com/Ocramius/array_change_keys-benchmark


Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On Sun, Jan 8, 2017 at 3:21 PM, Colin O'Dell <[email protected]> wrote:

> Greetings all,
>
> It's been a while since we introduced the array_change_keys RFC
> https://wiki.php.net/rfc/array_change_keys. During the discussion
> period
> there was a healthy mix of interest and critique. It seems all the major
> discussion points were covered, so I'd like to put this RFC to a vote to
> determine its fate.
>
> Therefore, voting is now open on the array_change_keys RFC:
> https://wiki.php.net/rfc/array_change_keys Voting will close 2017-01-23
> at
> 23:59:59 UTC.
>
> Mailing list discussion thread:
> https://marc.info/?l=php-internals&m=146452769326964&w=2
>
> Reddit discussion thread:
> https://www.reddit.com/r/PHP/comments/4ll1hg/rfc_array_change_keys/
>
> The implementation is also on 3v4l.org should you wish to test it out.
>
> Regards,
>
> Colin O'Dell
>
Kalle Sommer Nielsen
Re: [PHP-DEV] [RFC][VOTE] array_change_keys
January 08, 2017 04:50PM
Hi Marco

2017-01-08 15:43 GMT+01:00 Marco Pivetta <[email protected]>:
> * New warnings. No, please, we want `Throwable`: warnings are terrible

Only really chiming in for the warnings part; warnings should not be a
blocker for a new feature, because it would create an inconsistency
with that function and the rest. If we were to implement a Throwable
technique for such, then it should be done for everything instead,
like all ext/standard or ext/whatever and that is a lot of work, we
just need someone to start the movement if it is so desired.



--
regards,

Kalle Sommer Nielsen
kalle@php.net

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Colin O'Dell
Re: [PHP-DEV] [RFC][VOTE] array_change_keys
January 10, 2017 02:20PM
Hearing no objections, voting is now halted and the RFC is back to "Under
Discussion".

Cheers,
Colin

On Mon, Jan 9, 2017 at 2:40 PM Colin O'Dell <[email protected]> wrote:

> Due to concerns that have not been adequately addressed during the
> discussion period, and mailing list issues which might be impacting the
> ability to discuss the RFC and/or its vote, I'd like to halt voting and
> revert this RFC to "Under Discussion". Are there any objections to this?
>
> On Mon, Jan 9, 2017 at 2:23 PM Levi Morrison <[email protected]> wrote:
>
> I kindly request that this voting be delayed until the mailing list
> issues are completely fixed.
>
> The mailing list software still rejects some messages with URLs; this
> was seemingly fixed but I am unable to send any messages with URLs in
> them, including quoting the original message.
>
>
Sorry, only registered users may post in this forum.

Click here to login