Welcome! Log In Create A New Profile

Advanced

[PATCH] ARM: mxs/tx28: fix odd include

Posted by Paul Bolle 
Paul Bolle
[PATCH] ARM: mxs/tx28: fix odd include
June 28, 2012 12:50PM
arch/arm/mach-mxs/module-tx28.c includes "../devices-mx28.h". That's a
bit odd, because that header can be found in the same directory. This
only works because arch/arm/mach-mxs/include should be in the header
search path for this file. Nevertheless, this file can simply include
"device-mx28.h" (just as the four other files including that header do).

Signed-off-by: Paul Bolle <[email protected]>
---
0) Untested, but obviously correct.

arch/arm/mach-mxs/module-tx28.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mxs/module-tx28.c b/arch/arm/mach-mxs/module-tx28.c
index 9a7b08b..0f71f82 100644
--- a/arch/arm/mach-mxs/module-tx28.c
+++ b/arch/arm/mach-mxs/module-tx28.c
@@ -11,7 +11,7 @@
#include <linux/gpio.h>

#include <mach/iomux-mx28.h>
-#include "../devices-mx28.h"
+#include "devices-mx28.h"

#include "module-tx28.h"

--
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Shawn Guo
Re: [PATCH] ARM: mxs/tx28: fix odd include
June 29, 2012 03:00AM
On Thu, Jun 28, 2012 at 12:39:05PM +0200, Paul Bolle wrote:
> arch/arm/mach-mxs/module-tx28.c includes "../devices-mx28.h". That's a
> bit odd, because that header can be found in the same directory. This
> only works because arch/arm/mach-mxs/include should be in the header
> search path for this file. Nevertheless, this file can simply include
> "device-mx28.h" (just as the four other files including that header do).
>
> Signed-off-by: Paul Bolle <[email protected]>

Applied, thanks.

Regards,
Shawn

> ---
> 0) Untested, but obviously correct.
>
> arch/arm/mach-mxs/module-tx28.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/module-tx28.c b/arch/arm/mach-mxs/module-tx28.c
> index 9a7b08b..0f71f82 100644
> --- a/arch/arm/mach-mxs/module-tx28.c
> +++ b/arch/arm/mach-mxs/module-tx28.c
> @@ -11,7 +11,7 @@
> #include <linux/gpio.h>
>
> #include <mach/iomux-mx28.h>
> -#include "../devices-mx28.h"
> +#include "devices-mx28.h"
>
> #include "module-tx28.h"
>
> --
> 1.7.7.6
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Sorry, only registered users may post in this forum.

Click here to login