Welcome! Log In Create A New Profile


[PATCH 1026/1285] Replace numeric parameter like 0444 with macro

Posted by Baole Ni 
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <[email protected]>
Signed-off-by: Baole Ni <[email protected]>
drivers/watchdog/diag288_wdt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/diag288_wdt.c b/drivers/watchdog/diag288_wdt.c
index 861d3d3..75bfe07 100644
--- a/drivers/watchdog/diag288_wdt.c
+++ b/drivers/watchdog/diag288_wdt.c
@@ -60,13 +60,13 @@ MODULE_AUTHOR("Philipp Hachtmann <[email protected]>");

MODULE_DESCRIPTION("System z diag288 Watchdog Timer");

-module_param_string(cmd, wdt_cmd, MAX_CMDLEN, 0644);
+module_param_string(cmd, wdt_cmd, MAX_CMDLEN, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(cmd, "CP command that is run when the watchdog triggers (z/VM only)");

-module_param_named(conceal, conceal_on, bool, 0644);
+module_param_named(conceal, conceal_on, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(conceal, "Enable the CONCEAL CP option while the watchdog is active (z/VM only)");

-module_param_named(nowayout, nowayout_info, bool, 0444);
+module_param_named(nowayout, nowayout_info, bool, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default = CONFIG_WATCHDOG_NOWAYOUT)");

Sorry, only registered users may post in this forum.

Click here to login