Welcome! Log In Create A New Profile


[PATCH 1045/1285] Replace numeric parameter like 0444 with macro

Posted by Baole Ni 
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <[email protected]>
Signed-off-by: Baole Ni <[email protected]>
fs/jfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index cec8814..c348410 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -67,7 +67,7 @@ struct task_struct *jfsSyncThread;

int jfsloglevel = JFS_LOGLEVEL_WARN;
-module_param(jfsloglevel, int, 0644);
+module_param(jfsloglevel, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(jfsloglevel, "Specify JFS loglevel (0, 1 or 2)");

Sorry, only registered users may post in this forum.

Click here to login