Justin Karneges
patch: on-marked-up option
May 25, 2012 12:30AM
Hi,

This implements the feature discussed in the earlier thread of killing
connections on backup servers when a non-backup server comes back up. For
example, you can use this to route to a mysql master & slave and ensure
clients don't stay on the slave after the master goes from down->up. I've done
some minimal testing and it seems to work.

Today is the first time I ever looked at haproxy's code but this feature seemed
straightforward enough to implement. I hope I've done it properly.

Justin
Willy Tarreau
Re: patch: on-marked-up option
June 03, 2012 11:30PM
Hi Justin,

sorry I didn't notice your mail!

On Thu, May 24, 2012 at 03:28:52PM -0700, Justin Karneges wrote:
> Hi,
>
> This implements the feature discussed in the earlier thread of killing
> connections on backup servers when a non-backup server comes back up. For
> example, you can use this to route to a mysql master & slave and ensure
> clients don't stay on the slave after the master goes from down->up. I've done
> some minimal testing and it seems to work.
>
> Today is the first time I ever looked at haproxy's code but this feature seemed
> straightforward enough to implement. I hope I've done it properly.

I think that overall it's fine. I'm going to add minor restrictions to the
UP server before killing backup connections :
- ensure that it's not backup (otherwise it can make things worse when
you have multiple backup servers)
- ensure that its weight is > 0, otherwise it will not get any traffic


I'll also add some basic doc for this new option.

Thanks,
Willy
Justin Karneges
Re: patch: on-marked-up option
June 04, 2012 05:20AM
On Sunday, June 03, 2012 02:19:54 PM Willy Tarreau wrote:
> I think that overall it's fine. I'm going to add minor restrictions to the
> UP server before killing backup connections :
> - ensure that it's not backup (otherwise it can make things worse when
> you have multiple backup servers)
> - ensure that its weight is > 0, otherwise it will not get any traffic
>
>
> I'll also add some basic doc for this new option.

Sounds great. And I'm glad to see the dev11 release. Thanks!

Justin
Sorry, only registered users may post in this forum.

Click here to login