Welcome! Log In Create A New Profile

Advanced

commit #f9cc07c25b: compilation error when threads are disabled

Posted by Cyril Bonté 
Cyril Bonté
commit #f9cc07c25b: compilation error when threads are disabled
September 11, 2018 10:10PM
Hi William,

I won't have time to provide a patch tonight and maybe you're still
reorganizing some code.
My compilation test scripts are reporting that commit #f9cc07c25b broke
the compilation when threads are disabled (USE_THREAD=) :

src/haproxy.c: In function ‘mworker_loop’:
src/haproxy.c:870:6: error: lvalue required as left operand of assignment
tid = 0;
^

http://git.haproxy.org/?p=haproxy.git;a=commit;h=f9cc07c25beab93700044955d97117465b4852ae

I prefer to report the issue as I'm not sure you've seen it ;-)

--
Cyril Bonté
William Lallemand
Re: commit #f9cc07c25b: compilation error when threads are disabled
September 12, 2018 12:10PM
On Tue, Sep 11, 2018 at 10:04:47PM +0200, Cyril Bonté wrote:
> Hi William,
>
> I won't have time to provide a patch tonight and maybe you're still
> reorganizing some code.
> My compilation test scripts are reporting that commit #f9cc07c25b broke
> the compilation when threads are disabled (USE_THREAD=) :
>
> src/haproxy.c: In function ‘mworker_loop’:
> src/haproxy.c:870:6: error: lvalue required as left operand of assignment
> tid = 0;
> ^
>
> http://git.haproxy.org/?p=haproxy.git;a=commit;h=f9cc07c25beab93700044955d97117465b4852ae
>
> I prefer to report the issue as I'm not sure you've seen it ;-)
>

Hi Cyril,

Thanks for the report, removing the initialisation completely shouldn't be a problem.

Patch attached.

--
William Lallemand
On Wed, Sep 12, 2018 at 12:06:40PM +0200, William Lallemand wrote:
> Thanks for the report, removing the initialisation completely shouldn't be a problem.

Applied, thanks guys!
Willy
Sorry, only registered users may post in this forum.

Click here to login