Welcome! Log In Create A New Profile

Advanced

[PATCH][MINOR]: config: Warn if resolvers section has no namerservers configured

Posted by Ben Draut 
This implements a simple warning for 'resolvers' sections that have no
nameservers.

Previously discussed here:
https://www.mail-archive.com/[email protected]/msg29600.html

Thanks,

Ben
Hi Ben,

On Fri, Apr 13, 2018 at 03:51:17PM -0600, Ben Draut wrote:
> This implements a simple warning for 'resolvers' sections that have no
> nameservers.

Thank you, now merged. However :

> (Also trimmed lines with trailing whitespace in this file.)

Please don't do this, it needlessly inflates the patch, complicates
the review process and possibly makes backports more painful. While
it can sometimes be fine to fix these where you are editing, it's not
much welcome in other places, especially mixed with a feature. As a
rule of thumb, if a patch contains some hunks irrelevant to the patch's
initial purpose, these changes should be dropped.

Thanks,
Willy
Sorry, only registered users may post in this forum.

Click here to login