Welcome! Log In Create A New Profile

Advanced

stats page: inconsistent numbers spacing (thousands)

Posted by John Cherouvim 
John Cherouvim
stats page: inconsistent numbers spacing (thousands)
March 02, 2018 12:10PM
Hello

My stats page (haproxy version: 1.8.4-1ppa1~xenial) shows some values as
"20000" and others as "2 000" (note the thousands spacing). The CSV in
question shows the numbers without spaces:
> backend_varnish,varnish,0,0,0,0,20000,0,0,0,,0,,0,0,0,0,no check,1,1,0,,,92203,,,1,3,1,,0,,2,0,,0,,,,0,0,0,0,0,0,,,,,0,0,,,,,-1,,,0,0,0,0,,,,,,,,,,,,,,http,,,,,,,,
> backend_varnish,BACKEND,0,0,0,0,2000,0,0,0,0,0,,0,0,0,0,UP,1,1,0,,0,92203,0,,1,3,0,,0,,1,0,,0,,,,0,0,0,0,0,0,,,,0,0,0,0,0,0,0,-1,,,0,0,0,0,,,,,,,,,,,,,,http,,,,,,,,

Also, in the errors section it shows "25 131" (has space) in Errors >
Conns but "213832" (no space) in Warnings > Retr.

Is this an HTML templating bug of the stats page? Or is there a reason
for this kind of presentation?


thanks
Willy Tarreau
Re: stats page: inconsistent numbers spacing (thousands)
March 12, 2018 08:10AM
Hello John,

On Fri, Mar 02, 2018 at 01:04:11PM +0200, John Cherouvim wrote:
> Hello
>
> My stats page (haproxy version: 1.8.4-1ppa1~xenial) shows some values as
> "20000" and others as "2 000" (note the thousands spacing). The CSV in
> question shows the numbers without spaces:
> > backend_varnish,varnish,0,0,0,0,20000,0,0,0,,0,,0,0,0,0,no check,1,1,0,,,92203,,,1,3,1,,0,,2,0,,0,,,,0,0,0,0,0,0,,,,,0,0,,,,,-1,,,0,0,0,0,,,,,,,,,,,,,,http,,,,,,,,
> > backend_varnish,BACKEND,0,0,0,0,2000,0,0,0,0,0,,0,0,0,0,UP,1,1,0,,0,92203,0,,1,3,0,,0,,1,0,,0,,,,0,0,0,0,0,0,,,,0,0,0,0,0,0,0,-1,,,0,0,0,0,,,,,,,,,,,,,,http,,,,,,,,
>
> Also, in the errors section it shows "25 131" (has space) in Errors > Conns
> but "213832" (no space) in Warnings > Retr.
>
> Is this an HTML templating bug of the stats page? Or is there a reason for
> this kind of presentation?

It should not be a bug, the spacing is intentional to make large numbers more
readable. It's really important when you are looking at a large page with tens
of servers showing very large numbers. To give you an idea, a server delivering
10 Gbps of traffic will emit half a petabyte per week, and these numbers are
too large to remain readable. I tried to use larger units but that makes them
not move anymore (eg: for servers remaining up for a very long time), so in the
end, visually splitting the numbers seems like the best solution. It's possible
that it's not applied to every single number, as some such as connection errors
or retries are hardly supposed to be large. The way the spacing is done ensures
that you can still select the number and copy-paste it anywhere without copying
the spaces (eg for calculations). Ideally we should have small spaces on every
possibly large number.

Hoping this helps,
Willy
John Cherouvim
Re: stats page: inconsistent numbers spacing (thousands)
March 12, 2018 10:20AM
Hello Willy

I understand the need for spacing. My message was only regarding the
inconsistent usage of it (e.g "20000" vs "2 000"). Anyway, it's not
important, just something I found out and thought it was worth mentioning.

Thanks for answering this and, in general, for your great software.
John



Willy Tarreau wrote:
> Hello John,
>
> On Fri, Mar 02, 2018 at 01:04:11PM +0200, John Cherouvim wrote:
>
>> Hello
>>
>> My stats page (haproxy version: 1.8.4-1ppa1~xenial) shows some values as
>> "20000" and others as "2 000" (note the thousands spacing). The CSV in
>> question shows the numbers without spaces:
>>
>>> backend_varnish,varnish,0,0,0,0,20000,0,0,0,,0,,0,0,0,0,no check,1,1,0,,,92203,,,1,3,1,,0,,2,0,,0,,,,0,0,0,0,0,0,,,,,0,0,,,,,-1,,,0,0,0,0,,,,,,,,,,,,,,http,,,,,,,,
>>> backend_varnish,BACKEND,0,0,0,0,2000,0,0,0,0,0,,0,0,0,0,UP,1,1,0,,0,92203,0,,1,3,0,,0,,1,0,,0,,,,0,0,0,0,0,0,,,,0,0,0,0,0,0,0,-1,,,0,0,0,0,,,,,,,,,,,,,,http,,,,,,,,
>>>
>> Also, in the errors section it shows "25 131" (has space) in Errors > Conns
>> but "213832" (no space) in Warnings > Retr.
>>
>> Is this an HTML templating bug of the stats page? Or is there a reason for
>> this kind of presentation?
>>
>
> It should not be a bug, the spacing is intentional to make large numbers more
> readable. It's really important when you are looking at a large page with tens
> of servers showing very large numbers. To give you an idea, a server delivering
> 10 Gbps of traffic will emit half a petabyte per week, and these numbers are
> too large to remain readable. I tried to use larger units but that makes them
> not move anymore (eg: for servers remaining up for a very long time), so in the
> end, visually splitting the numbers seems like the best solution. It's possible
> that it's not applied to every single number, as some such as connection errors
> or retries are hardly supposed to be large. The way the spacing is done ensures
> that you can still select the number and copy-paste it anywhere without copying
> the spaces (eg for calculations). Ideally we should have small spaces on every
> possibly large number.
>
> Hoping this helps,
> Willy
>
>
Willy Tarreau
Re: stats page: inconsistent numbers spacing (thousands)
March 12, 2018 11:40AM
On Mon, Mar 12, 2018 at 11:09:00AM +0200, John Cherouvim wrote:
> Hello Willy
>
> I understand the need for spacing. My message was only regarding the
> inconsistent usage of it (e.g "20000" vs "2 000"). Anyway, it's not
> important, just something I found out and thought it was worth mentioning.

You're right, and possibly that it deserves being addressed if there are
only a few areas left. After all it's mostly used for counters and there
are not that many ;-)

Do you want to take a look at the code and see if you can fix it yourself
and provide a patch ? It should be in src/stats.c. If you're interested in
taking a look at it, please read CONTRIBUTING before submitting your patch,
in order to see how to format it and help you provide a good one on the
first attempt.

Cheers,
Willy
Sorry, only registered users may post in this forum.

Click here to login