Welcome! Log In Create A New Profile

Advanced

[PATCH] BUG/MINOR: http: fix typo in http_apply_redirect_rule

Posted by Christopher Faulet 
Christopher Faulet
[PATCH] BUG/MINOR: http: fix typo in http_apply_redirect_rule
March 20, 2017 11:20AM
Hi,

Here is a little patch fixing a bug. It should be backported in 1.7.

Thanks,
--
Christopher Faulet
On Mon, Mar 20, 2017 at 11:08:20AM +0100, Christopher Faulet wrote:
> Hi,
>
> Here is a little patch fixing a bug. It should be backported in 1.7.

Thanks Christopher. Are you sure it's *this* minor ? I suspect that not
having it could break keep-alive processing on redirect rules, am I wrong ?

Thanks,
Willy
Christopher Faulet
Re: [PATCH] BUG/MINOR: http: fix typo in http_apply_redirect_rule
March 21, 2017 11:20AM
Le 21/03/2017 à 07:43, Willy Tarreau a écrit :
> On Mon, Mar 20, 2017 at 11:08:20AM +0100, Christopher Faulet wrote:
>> Hi,
>>
>> Here is a little patch fixing a bug. It should be backported in 1.7.
>
> Thanks Christopher. Are you sure it's *this* minor ? I suspect that not
> having it could break keep-alive processing on redirect rules, am I wrong ?
>

Well, maybe you're right. In almost all cases, this bug has no effect.
After a more careful check, I found it leads to a memory leak if a
redirect is done on a http-response rule when the HTTP compression is
enabled.

So, I set it to MAJOR. Thanks
--
Christopher Faulet
On Tue, Mar 21, 2017 at 11:09:52AM +0100, Christopher Faulet wrote:
> Le 21/03/2017 à 07:43, Willy Tarreau a écrit :
> > On Mon, Mar 20, 2017 at 11:08:20AM +0100, Christopher Faulet wrote:
> > > Hi,
> > >
> > > Here is a little patch fixing a bug. It should be backported in 1.7.
> >
> > Thanks Christopher. Are you sure it's *this* minor ? I suspect that not
> > having it could break keep-alive processing on redirect rules, am I wrong ?
> >
>
> Well, maybe you're right. In almost all cases, this bug has no effect. After
> a more careful check, I found it leads to a memory leak if a redirect is
> done on a http-response rule when the HTTP compression is enabled.
>
> So, I set it to MAJOR. Thanks

Thanks for the explanation. Now merged.

willy
Sorry, only registered users may post in this forum.

Click here to login