Serverphorums.com - php-internals

[PHP-DEV] ZEND_NS_NAMED_FE is clearly a frequently used macro (1 reply)

Sara Golemon — Tue, 21 May 2013 20:30:02 +0200

It's time to play "Spot the double quoting!"

#define ZEND_NS_FENTRY(ns, zend_name, name, arg_info, flags)
ZEND_RAW_FENTRY(ZEND_NS_NAME(ns, #zend_name), name, arg_info, flags)

#define ZEND_NS_NAMED_FE(ns, zend_name, name, arg_info) ZEND_NS_FENTRY(ns,
#zend_name, name, arg_info, 0)

ZEND_NS_NAMED_FE("foo", bar, ...)

Gets exported to userspace as: foo\"bar" which is obviously fail.

Any objections to my fixing ZEND_NS_NAMED_FE as: s/#zend/zend/ ?

-Sara

[PHP-DEV] [Proposal] Add method to shmop ext to retrieve OS shmid (no replies)

Erik Nedwidek — Sun, 19 May 2013 03:40:02 +0200

This grew out of a question I answered on StackOverflow.com:
http://stackoverflow.com/questions/16501707/working-with-shared-memory-in-php/

The gist is that a user was converting a C program to PHP and wanted
the shmid as reported by ipcs. The user assumed that the id returned
by shmop_open would be the shmid, and was confused by the shmop
resource identifier. (I explained to him what the return actually was)

I suggested he use his own unique key to be able to identify the
shared memory created for his script, but he said that it had to be
0x0.

I've added a function to retrieve shmop->shmid in my own fork of PHP.
You can see the changes here and the commit message contains a quick
usage/test script:
https://github.com/nedwidek/php-src/commit/832e77fce15de926b562b6dcc28d1864bb7c348b

So I guess the questions are:
Is there a particular reason that the shmid is hidden from PHP scripts?
Is there any reason not to move this to a formal RFC?
Should similar methods be added to the sysv* extensions where applicable?
Assuming this is an acceptable change to consider, anyone have a
better function name than shmop_sys_shmid?

Regards,
Erik Nedwidek

[PHP-DEV] hash_pbkdf2 vs openssl_pbkdf2 (no replies)

Nikita Popov — Sat, 18 May 2013 11:50:02 +0200

Hi internals!

I just noticed that we added the PBKDF2 algorithm two times in PHP 5.5.
Once in the hash extension, once in the OpenSSL extension.

The hash_pbkdf2 function was added via this RFC:
https://wiki.php.net/rfc/hash_pbkdf2

The openssl_pbkdf2 function probably was not noticed at that time because
it was just commited, but not mentioned anywhere else (NEWS, UPGRADING,
etc). Only saw it in vrana's documentation updates just now. The relevant
commit is here: https://github.com/php/php-src/commit/f4847ef

It would be nice if we could have only one of those functions. I'm
currently tending towards the hash_ variant because of the commit message
of the openssl_ function:

> No easy way to put these in the hash extension since we don't really
support optional
> parameters to certain algorithms. Implemented in openssl for now since it
has it already
> and is pretty stable.
>
> Only SHA1 is confirmed to work as an algorithm but openssl has a
parameter so it can be
> changed in the future.

It seems that the author already would have preferred it in the hash
extension and that the openssl variant only works with sha1 (or was only
tested with it? not sure).

Nikita

[PHP-DEV] Re: [PHP-CVS] com php-src: Add optional second arg to unserialize(): ext/standard/basic_functions.c ext/standard/tests/serialize/serialization_error_001.phpt ext/standard/tests/serialize/unserialize_consumed.phpt ext/standard/var.c (no replies)

Stas Malyshev — Fri, 17 May 2013 19:20:01 +0200

Hi!

> Imho this should have been briefly discussed on internals beforehand. At
> least to me this seems rather dubious (why is it needed? why are you
> manually parsing a part of the DLL serialization?) and also clashes with
> Stas' proposed changes to unserialize.

I don't remember any discussion and I think it's rather sad that we're
back to "commit first, ask anybody else maybe" paradigm. There
definitely should be notification on the list prior to changing API of
one of the very frequently used functions in the core.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Stand alone GD status? (2 replies)

Chris Barker - NOAA Federal — Sat, 18 May 2013 00:20:05 +0200

Hi Folks,

I tried to post this note via the web interace, but I don't think it made
it, so here it is again. I finally figured out how to subscribe to the list
properly.

(side NOTE: how to subscribe to the lists is very poorly documented --
there is nice whole page about all the php lists, but no links or docs
about how to subscribe. Elsewhere, I found how to subscribe to php-general,
and extrapolated from that -- however, it took a bunch of failed attempts,
and much frustration, before I figured out that list list is called
"internals" rather than "php.internals" or "php-internals", or ???. But I
guess that weeds out the less-persistent!)

Sorry if it's a repeat.

I'm interesting in the status of the GD lib as a stand-alone library. I'd
like to use it on it's own, and perhaps write some new python bindings for
it.

But as we all know the state of libGD's web presence is confusing (though
recently improved). I have found it hard to:

1) know which source code I should use
2) find the docs
3) figure out where to ask questions, perhaps post patches, etc. (why I'm
posting to this list)

So;

a) is there a mailing list or something that I missed?
b) is there interest (probably from Pierre or Tom) to continue to maintain
it, clean up its web presence, etc.? (note -- there really isn'ta ll that
much to do to improve the situation a lot -- simply putting all the code,
docs, and a small info page all in one place, and having a mailing list)

I like GD, as it is simple, fast, and does what I need it to do. I'd rather
not get into the mess of Cairo, or AGG, or skia (though skia does look
pretty promising...). But I do need to know that there's some support
before committing much effort to it.

-Chris

--

Christopher Barker, Ph.D.
Oceanographer

Emergency Response Division
NOAA/NOS/OR&R (206) 526-6959 voice
7600 Sand Point Way NE (206) 526-6329 fax
Seattle, WA 98115 (206) 526-6317 main reception

Chris.Barker@noaa.gov

[PHP-DEV] php-fpm and systemd integration (5 replies)

Remi Collet — Thu, 23 May 2013 07:20:02 +0200

Hi,

I plan to allow php-fpm to be aware of systemd and so, use the
type=notify mode.

I'd like to apply to attached patch to 5.4 and 5.5, as this change have
no impact on standard build (need new --with-fpm-systemd build option).

Any feedback before I process ?

Remi.
diff -up ../sapi/fpm/config.m4.systemd ../sapi/fpm/config.m4
--- ../sapi/fpm/config.m4.systemd 2013-05-08 18:45:31.000000000 +0200
+++ ../sapi/fpm/config.m4 2013-05-17 12:20:19.199841304 +0200
@@ -563,6 +563,26 @@ if test "$PHP_FPM" != "no"; then
[ --with-fpm-group[=GRP] Set the group for php-fpm to run as. For a system user, this
should usually be set to match the fpm username (default: nobody)], nobody, no)

+ PHP_ARG_WITH(fpm-systemd,,
+ [ --with-fpm-systemd Activate systemd integration], no, no)
+
+ if test "$PHP_FPM_SYSTEMD" != "no" ; then
+ AC_CHECK_LIB(systemd-daemon, sd_notify, SYSTEMD_LIBS="-lsystemd-daemon")
+ AC_CHECK_HEADERS(systemd/sd-daemon.h, [HAVE_SD_DAEMON_H="yes"], [HAVE_SD_DAEMON_H="no"])
+ if test $HAVE_SD_DAEMON_H = "no" || test -z "${SYSTEMD_LIBS}"; then
+ AC_MSG_ERROR([Your system does not support systemd.])
+ else
+ AC_DEFINE(HAVE_SYSTEMD, 1, [FPM use systemd integration])
+ PHP_FPM_SD_FILES="fpm/fpm_systemd.c"
+ PHP_ADD_LIBRARY(systemd-daemon)
+ php_fpm_systemd=notify
+ fi
+ else
+ php_fpm_systemd=simple
+ fi
+ PHP_SUBST_OLD(php_fpm_systemd)
+ AC_DEFINE_UNQUOTED(PHP_FPM_SYSTEMD, "$php_fpm_systemd", [fpm systemd service type])
+
if test -z "$PHP_FPM_USER" -o "$PHP_FPM_USER" = "yes" -o "$PHP_FPM_USER" = "no"; then
php_fpm_user="nobody"
else
@@ -631,7 +651,7 @@ if test "$PHP_FPM" != "no"; then
fpm/events/port.c \
"

- PHP_SELECT_SAPI(fpm, program, $PHP_FPM_FILES $PHP_FPM_TRACE_FILES, $PHP_FPM_CFLAGS, '$(SAPI_FPM_PATH)')
+ PHP_SELECT_SAPI(fpm, program, $PHP_FPM_FILES $PHP_FPM_TRACE_FILES $PHP_FPM_SD_FILES, $PHP_FPM_CFLAGS, '$(SAPI_FPM_PATH)')

case $host_alias in
*aix*)
diff -up ../sapi/fpm/fpm/fpm_events.c.systemd ../sapi/fpm/fpm/fpm_events.c
--- ../sapi/fpm/fpm/fpm_events.c.systemd 2013-05-08 18:45:31.000000000 +0200
+++ ../sapi/fpm/fpm/fpm_events.c 2013-05-17 13:13:10.854896820 +0200
@@ -29,6 +29,10 @@
#include "events/port.h"
#include "events/kqueue.h"

+#ifdef HAVE_SYSTEMD
+#include "fpm_systemd.h"
+#endif
+
#define fpm_event_set_timeout(ev, now) timeradd(&(now), &(ev)->frequency, &(ev)->timeout);

static void fpm_event_cleanup(int which, void *arg);
@@ -361,6 +365,10 @@ void fpm_event_loop(int err) /* {{{ */

zlog(ZLOG_DEBUG, "%zu bytes have been reserved in SHM", fpm_shm_get_size_allocated());
zlog(ZLOG_NOTICE, "ready to handle connections");
+
+#ifdef HAVE_SYSTEMD
+ fpm_systemd_heartbeat(NULL, 0, NULL);
+#endif
}

while (1) {
diff -up ../sapi/fpm/fpm/fpm_systemd.c.systemd ../sapi/fpm/fpm/fpm_systemd.c
--- ../sapi/fpm/fpm/fpm_systemd.c.systemd 2013-05-17 12:20:19.200841309 +0200
+++ ../sapi/fpm/fpm/fpm_systemd.c 2013-05-17 14:18:36.851079208 +0200
@@ -0,0 +1,74 @@
+#include "fpm_config.h"
+
+#include
+#include
+
+#include "fpm.h"
+#include "fpm_clock.h"
+#include "fpm_worker_pool.h"
+#include "fpm_scoreboard.h"
+#include "zlog.h"
+#include "fpm_systemd.h"
+
+
+static void fpm_systemd() /* {{{ */
+{
+ static unsigned long int last=0;
+ struct fpm_worker_pool_s *wp;
+ unsigned long int requests=0, slow_req=0;
+ int active=0, idle=0, rv;
+
+
+ for (wp = fpm_worker_all_pools; wp; wp = wp->next) {
+ if (wp->scoreboard) {
+ active += wp->scoreboard->active;
+ idle += wp->scoreboard->idle;
+ requests += wp->scoreboard->requests;
+ slow_req += wp->scoreboard->slow_rq;
+ }
+ }
+/*
+ zlog(ZLOG_DEBUG, "systemd heartbeat (Processes active:%d, idle:%d, Requests:%lu, slow:%lu, Traffic:%.3greq/sec)",
+ active, idle, requests, slow_req, ((float)requests - last) * 1000.0 / FPM_SYSTEMD_HEARTBEAT);
+*/
+ rv = sd_notifyf(0, "READY=1\n"
+ "STATUS=Processes active: %d, idle: %d, Requests: %lu, slow: %lu, Traffic: %.3greq/sec",
+ active, idle, requests, slow_req, ((float)requests - last) * 1000.0 / FPM_SYSTEMD_HEARTBEAT);
+
+ if (rv < 0) {
+ zlog(ZLOG_NOTICE, "failed to notify systemd");
+ }
+
+ last = requests;
+}
+/* }}} */
+
+void fpm_systemd_heartbeat(struct fpm_event_s *ev, short which, void *arg) /* {{{ */
+{
+ static struct fpm_event_s heartbeat;
+
+ if (fpm_globals.parent_pid != getpid()) {
+ return; /* sanity check */
+ }
+
+ if (which == FPM_EV_TIMEOUT) {
+ fpm_systemd();
+
+ return;
+ }
+
+ if (sd_notifyf(0, "READY=1\n"
+ "STATUS=ready to handle connections\n"
+ "MAINPID=%lu",
+ (unsigned long) getpid()) < 0) {
+ zlog(ZLOG_WARNING, "failed to notify systemd");
+ } else {
+ zlog(ZLOG_DEBUG, "have notify systemd");
+ }
+
+ /* first call without setting which to initialize the timer */
+ fpm_event_set_timer(&heartbeat, FPM_EV_PERSIST, &fpm_systemd_heartbeat, NULL);
+ fpm_event_add(&heartbeat, FPM_SYSTEMD_HEARTBEAT);
+}
+/* }}} */
+
diff -up ../sapi/fpm/fpm/fpm_systemd.h.systemd ../sapi/fpm/fpm/fpm_systemd.h
--- ../sapi/fpm/fpm/fpm_systemd.h.systemd 2013-05-17 12:20:19.200841309 +0200
+++ ../sapi/fpm/fpm/fpm_systemd.h 2013-05-17 14:02:37.400247799 +0200
@@ -0,0 +1,12 @@
+#ifndef FPM_SYSTEMD_H
+#define FPM_SYSTEMD_H 1
+
+#include "fpm_events.h"
+
+/* 10s (in ms) heartbeat for systemd status */
+#define FPM_SYSTEMD_HEARTBEAT (10000)
+
+void fpm_systemd_heartbeat(struct fpm_event_s *ev, short which, void *arg);
+
+#endif
+
diff -up ../sapi/fpm/php-fpm.service.in.systemd ../sapi/fpm/php-fpm.service.in
--- ../sapi/fpm/php-fpm.service.in.systemd 2013-05-08 18:45:31.000000000 +0200
+++ ../sapi/fpm/php-fpm.service.in 2013-05-17 12:20:19.201841314 +0200
@@ -3,6 +3,7 @@ Description=The PHP FastCGI Process Mana
After=syslog.target network.target

[Service]
+Type=@php_fpm_systemd@
PIDFile=@localstatedir@/run/php-fpm.pid
ExecStart=@sbindir@/php-fpm --nodaemonize --fpm-config @sysconfdir@/php-fpm.conf
ExecReload=/bin/kill -USR2 $MAINPID
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Firebird PDO Fixes (1 reply)

Matheus Degiovani — Mon, 20 May 2013 09:40:02 +0200

Hello,

I have some fixes for pdo-firebird I sent as pull requests on github. I
contacted the php developer Mariuz, but he's currently busy and is unable
to review and commit the changes to master.

Could someone please review them for inclusion in the next php release?

Thanks.

--
Matheus Degiovani
Gigatron Franchising
(18) 3642-9008
MSN: matheus@gigatron.com.br

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Memory leak in include()/require() ? (8 replies)

peter wang — Fri, 17 May 2013 10:00:05 +0200

hi, did anyone come across the memory leak of require()/include(),
I just saw this bug report: https://bugs.php.net/bug.php?id=47038,
but it was closed with nothing explained.

the php version I used:

php --version
PHP 5.3.6-13ubuntu3.9 with Suhosin-Patch (cli) (built: Sep 12 2012 19:00:27)
Copyright (c) 1997-2011 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2011 Zend Technologies

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] OPCache documentation (no replies)

Julien Pauli — Wed, 15 May 2013 16:00:02 +0200

Hi all,

As you know, 5.5 final is coming soon.
We are in RC, so mainly stabilizing stuff and preparing the final release
for anyone to setup 5.5 on their servers.

I see the documentation migration guide has already been commited, that's a
good new.
I also see that new features we ship in 5.5 are online in the
documentation, great !

But a crucial feature is missing doc : OPCache.

As this feature is a very big step in PHP's life (we finally have a
recommanded, bundled opcode cache system, and I'm very proud of this
personnaly), I think it is crucial to have a good documentation about it.

Has anyone started to write some doc about OPCache ?

Another subject is APC. We have its doc on php.net, all right.
What I would like is we patch APC doc when 5.5 final gets released, to
clearly show our mind about it.
That way, any people using 5.5 should be able to read in the doc that APC
has support has been interrupted, that APC should never be used together
with OPCache, and that OPCache is now the standard recommanded OPCode
caching solution for 5.5, 5.4 and 5.3.

It is crucial to communicate one this point for our users.

Then will come the "User cache" debate

Thank you.

Julien.Pauli

[PHP-DEV] [PROPOSAL] apparmor change_hat functionality in fpm (no replies)

Gernot Vormayr — Wed, 15 May 2013 15:10:02 +0200

Hi!

The basic idea behind this is to get a better seperation of different php
pools (so e.g. php scripts from one pool can't access the other and vice
versa).

I did a small patch (https://github.com/php/php-src/pull/343) that adds a
configuration parameter to pools (apparmor_hat). If this is set, workers of
the pool try to change the apparmor hat to the specified value.
The patch only touches fpm. Only thing that's needed is libapparmor - if it
is not there the functionality just gets left out.

To keep things simple this version is very coarse - meaning it is not
possible to change the hat back, or change to a different hat according to
the executed script.

Any thoughts on this?

Cheers,
Gernot

[PHP-DEV] [PROPOSAL] apparmor change_hat functionality in fpm (no replies)

Gernot Vormayr — Wed, 15 May 2013 15:10:02 +0200

[PHP-DEV] MultipleIterator, add a default value (no replies)

Ivan Enderlin @ Hoa — Tue, 14 May 2013 10:40:03 +0200

Hi internals,

I propose to ameliorate the MultipleIterator class.

When a MultipleIterator instance has the MIT_NEED_ANY flag, and when one
of the attached iterators has reached its end, the returned value is
NULL. I propose to change this behavior by allowing a different default
value.

Example with no default value:

$it = new \MultipleIterator(
\MultipleIterator::MIT_NEED_ANY
| \MultipleIterator::MIT_KEYS_ASSOC
);
$it->attachIterator(new \ArrayIterator(['a', 'b', 'c']), 'foo');
$it->attachIterator(new \ArrayIterator(['x']), 'bar');

foreach($it as $value)
echo $value['foo'], ' => ', $value['bar'], "\n";

/**
* Will output:
* a => x
* b =>
* c =>
*/

Example with 42 as a default value (given as a third parameter of the
MultipleIterator::attachIterator method):

$it->attachIterator(new \ArrayIterator(['a', 'b', 'c']), 'foo', 42);
$it->attachIterator(new \ArrayIterator(['x']), 'bar', 42);

foreach($it as $value)
echo $value['foo'], ' => ', $value['bar'], "\n";

/**
* Will output:
* a => x
* b => 42
* c => 42
*/

It is clearly useful when one of the iterators returns an array, used
directly in a loop. To avoid a "NULL pointer exception", we can specify
an empty array as a default value.

A PHP implementation is pretty easy to do. Naively, we are able to write
https://github.com/hoaproject/Iterator/commit/59dcff7f331a7338644cf9a8965d2a934a38661e.

If you think it can be useful, I propose to write a RFC with a patch.

Thoughts?

--
Ivan Enderlin
Developer of Hoa
http://hoa-project.net/

PhD. student at DISC/Femto-ST (Vesontio) and INRIA (Cassis)
http://disc.univ-fcomte.fr/ and http://www.inria.fr/

Member of HTML and WebApps Working Group of W3C
http://w3.org/

[PHP-DEV] Heads up - PECL ZendOptimizerPlus repository moved to github.com/zendtech/ZendOptimizerPlus (1 reply)

Zeev Suraski — Mon, 13 May 2013 16:10:03 +0200

For those of you with direct clones of ZendOptimizerPlus, you’d have to run:

git remote set-url origin git@github.com:zendtech/ZendOptimizerPlus.git

on your clones for them to continue working. This is not related to the
code that’s already inside the PHP tree.

Zeev

[PHP-DEV] [RFC] Internal operator overloading and GMP improvements (17 replies)

Nikita Popov — Wed, 15 May 2013 07:20:01 +0200

Hi internals!

https://wiki.php.net/rfc/operator_overloading_gmp

This RFC proposes to add operator overloading for INTERNAL classes.
Furthermore it exemplarily implements the new API for GMP.

Thanks,
Nikita

[PHP-DEV] How about make php php-cgi php-fpm to use a common shared library. (1 reply)

xinglp — Sat, 11 May 2013 11:20:02 +0200

This is my ugly patch for this.

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] com php-src: Address feature request #38917 for native SPKAC (HTML5 keygen element) support: ext/openssl/openssl.c ext/openssl/php_openssl.h ext/openssl/tests/openssl_spki_export.phpt ext/openssl/tests/openssl_spki_export_challenge (10 replies)

Sebastian Bergmann — Tue, 21 May 2013 17:20:02 +0200

Am 07.05.2013 00:36, schrieb Jason Gerfen:
> Commit: 8f56ac8401ed1c3e00b8fba3fb8e5efb565180c4
> Author: jas- Mon, 6 May 2013 16:36:06 -0600
> Parents: da07e91c3a7e7bac2e380f24c59f70c1bcb3e7e4
> Branches: master
>
> Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=8f56ac8401ed1c3e00b8fba3fb8e5efb565180c4
>
> Log:
> Address feature request #38917 for native SPKAC (HTML5 keygen element) support
>
> Bugs:
> https://bugs.php.net/38917
>
> Changed paths:
> M ext/openssl/openssl.c
> M ext/openssl/php_openssl.h
> A ext/openssl/tests/openssl_spki_export.phpt
> A ext/openssl/tests/openssl_spki_export_challenge.phpt
> A ext/openssl/tests/openssl_spki_new.phpt
> A ext/openssl/tests/openssl_spki_verify.phpt

Any chance of getting this into PHP 5.5? This patch has been waiting
around since 2006 ...

--
Sebastian Bergmann Co-Founder and Principal Consultant
http://sebastian-bergmann.de/ http://thePHP.cc/

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] exceptions during __toString() (3 replies)

Rasmus Schultz — Fri, 10 May 2013 13:00:02 +0200

I just ran into this issue again:

http://stackoverflow.com/questions/2429642/why-its-impossible-to-throw-exception-from-tostring

Instead of throwing some nonsense "you're not allowed to throw from here"
error-message, how about actually unwinding the stack and passing the
exception to the global exception-handler?

I understand there's a technical limitation making it difficult/impossible
to handle exceptions during __toString() - and it looks like you can still
try {...} catch (Exception $e) in __toString() just fine, but then what?
You have the exception, but you have no way to pass it to the standard
global exception-handler.

If the script has to terminate either way, why not terminate the same way
an unhandled exception would normally cause the script to terminate?

E.g. output the actual error-message, or pass it to whatever was registered
with register_exception_handler() so it can be output or handled in the
usual way?

[PHP-DEV] 5.4.15 and PHP 5.3.25 released! (no replies)

Stas Malyshev — Thu, 09 May 2013 21:00:01 +0200

Hello!

The PHP development team announces the immediate availability of PHP
5.4.15 and PHP 5.3.25. These releases fix about 10 bugs. All users of
PHP are encouraged to upgrade to PHP 5.4. PHP 5.3.25 is recommended
for those wishing to remain on the 5.3 series.

The full list of changes are recorded in the ChangeLog on
http://www.php.net/ChangeLog-5.php

For source downloads of PHP 5.4.15 and PHP 5.3.25 please visit our
downloads page at http://www.php.net/downloads.php

Windows binaries can be found on http://windows.php.net/download/

Stanislav Malyshev Johannes Schlüter
PHP 5.4 Release Master PHP 5.3 Release Master

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] list() inside a foreach() (3 replies)

Stefan Neufeind — Thu, 09 May 2013 18:50:02 +0200

Hi,

trying out the following source I was astonished to see that using
list() does not work directly in a foreach() but works fine if used
through a temporary variable.

Would allowing using list() inside the foreach()-statement be desired
behaviour? Or is it just me? :-)

$a = array(
array(5, 'A'),
array(3, 'B'),
);
foreach($a as list($k, $v)) {
echo $k;
}

Expected output: 53

Result: syntax error, unexpected 'list' (T_LIST) in ...

Works:
foreach($a as $b) {
list($k, $v) = $b;
echo $k;
}

Kind regards,
Stefan

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] PHP 5.5 and APC user cache upgrade path (7 replies)

Pierre Schmitz — Sat, 11 May 2013 15:00:01 +0200

Hi,

I am testing PHP 5.5 atm and how we can package it for Arch Linux and
provide an upgrade path for users. The RC1 looks pretty solid so far.

As the new opcache does not provide a user cache to store custom
variables, I would be glad if you could clarify what the best migration
from 5.4 would be.
* Is APC basically dead and wont support PHP 5.5?
* Should APC users switch to opcache and APCu? (with APCu replacing the
APC package)

For PHP application developers:
* Regarding APCu: it provides the old PHP interface function as well as
their own apcu_* functions. They are aliases right now. Should
application developers think about switching to the apcu_-API as new
features will be available only here?

Bonus question:
* Right now very similar functionality is provided by APCu, XCache,
WinCache, YAC etc.. Are there plans to include such functionality inside
PHP in future to make application developers life a little easier? At
least a common API would be great. There were several bugs in
applications as these modules behave a little different regarding return
values etc..

Greetings,

Pierre

--
Pierre Schmitz, https://pierre-schmitz.com

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] First RC of PHP5.5 available (no replies)

Julien Pauli — Thu, 09 May 2013 11:00:02 +0200

Hi Internals,

Our RC1 of PHP 5.5.0 has been released for testing. It fixes some bugs and
possible memleaks against last beta.
You'll find details in the NEWS file.

The packages can be found at:

http://downloads.php.net/dsp

and windows packages at

http://windows.php.net/qa

Please test the release carefully and report any bugs.

We are now RC, this means stability only.
Next RC is expected for May 23h.

Thanks you all contributors.

Regards
Julien and David

[PHP-DEV] [PATCH] faster and safer fpm config reading (no replies)

Martin Pelikan — Wed, 08 May 2013 02:30:03 +0200

commit edae18ccf5c51ae0bcc0e9655ead7540fd42dd9f
Author: Martin Pelikan
Date: Wed May 8 02:06:09 2013 +0200

Faster and safer parsing of fpm configuration.

The current fpm config parser did a read(2) syscall per character,
which obfuscated debugging strace/ktrace output somewhat. This also
makes the 1024 characters per line limit more explicit, so the users
will know what were they hitting.

It might improve performance during php-fpm load (.03 vs .00 seconds
on my laptop) but primarily serves to help observing fpm system call
traces during deployment (in chroot for example).

Signed-off-by: Martin Pelikan

diff --git a/sapi/fpm/fpm/fpm_conf.c b/sapi/fpm/fpm/fpm_conf.c
index 0a8a0e3..e004934 100644
--- a/sapi/fpm/fpm/fpm_conf.c
+++ b/sapi/fpm/fpm/fpm_conf.c
@@ -1447,11 +1447,11 @@ static void fpm_conf_ini_parser(zval *arg1, zval *arg2, zval *arg3, int callback

int fpm_conf_load_ini_file(char *filename TSRMLS_DC) /* {{{ */
{
+ const int bufsize = 1024;
int error = 0;
- char buf[1024+1];
- int fd, n;
+ char buf[bufsize], *newl;
+ int fd, pos = 0;
int nb_read = 1;
- char c = '*';

int ret = 1;

@@ -1473,36 +1473,48 @@ int fpm_conf_load_ini_file(char *filename TSRMLS_DC) /* {{{ */
}

ini_lineno = 0;
+ memset(buf, 0, sizeof buf);
while (nb_read > 0) {
int tmp;
- memset(buf, 0, sizeof(char) * (1024 + 1));
- for (n = 0; n < 1024 && (nb_read = read(fd, &c, sizeof(char))) == sizeof(char) && c != '\n'; n++) {
- buf[n] = c;
- }
- buf[n++] = '\n';
- ini_lineno++;
- ini_filename = filename;
- tmp = zend_parse_ini_string(buf, 1, ZEND_INI_SCANNER_NORMAL, (zend_ini_parser_cb_t)fpm_conf_ini_parser, &error TSRMLS_CC);
- ini_filename = filename;
- if (error || tmp == FAILURE) {
- if (ini_include) free(ini_include);
- ini_recursion--;
- close(fd);
- return -1;
- }
- if (ini_include) {
- char *tmp = ini_include;
- ini_include = NULL;
- fpm_evaluate_full_path(&tmp, NULL, NULL, 0);
- fpm_conf_ini_parser_include(tmp, &error TSRMLS_CC);
- if (error) {
- free(tmp);
+
+ nb_read = read(fd, buf + pos, sizeof buf - pos);
+ pos = 0;
+
+ while ((newl = strchr(buf + pos, '\n')) != NULL) {
+ newl[0] = '\0';
+ ini_lineno++;
+ ini_filename = filename;
+ tmp = zend_parse_ini_string(buf + pos, 1, ZEND_INI_SCANNER_NORMAL, (zend_ini_parser_cb_t)fpm_conf_ini_parser, &error TSRMLS_CC);
+ ini_filename = filename;
+ if (error || tmp == FAILURE) {
+ if (ini_include) free(ini_include);
ini_recursion--;
close(fd);
return -1;
}
- free(tmp);
+ if (ini_include) {
+ char *tmp = ini_include;
+ ini_include = NULL;
+ fpm_evaluate_full_path(&tmp, NULL, NULL, 0);
+ fpm_conf_ini_parser_include(tmp, &error TSRMLS_CC);
+ if (error) {
+ free(tmp);
+ ini_recursion--;
+ close(fd);
+ return -1;
+ }
+ free(tmp);
+ }
+
+ pos = newl - buf + 1;
+ }
+ if (nb_read > 0 && pos == 0) {
+ zlog(ZLOG_ERROR, "line %u too long", ini_lineno + 1);
+ close(fd);
+ return -1;
}
+ memmove(buf, buf + pos, sizeof buf - pos);
+ pos = sizeof buf - pos;
}

ini_recursion--;

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] idea: implement a Comparable interface (12 replies)

Thomas Anderson — Wed, 08 May 2013 08:40:02 +0200

It'd be nice if, when doing $objA > $objB, that that'd invoke
$objA->__compareTo($objB) or something, much like Java's Comparable
interface.

[PHP-DEV] idea: letting the line number and file name be set via user_error (19 replies)

Thomas Anderson — Wed, 08 May 2013 01:10:07 +0200

If you do user_error('whatever') it'll show, as the line number for that
error, the line number on which that user_error() call is made. It'd be
nice if you could control the line number and file name that was displayed.
eg.

function test() {
user_error('whatever');
}

test();
?>

That'll say "Notice: whatever in ... on line 4" (ie. the line that the
user_error is on) instead of "Notice: whatever in ... on line 7" (ie. the
line that the call to the test() function is made).

If the displayed line numbers could be controlled by user_error then
debug_backtrace could be used to get the desired line number / file name to
display.

[PHP-DEV] Adding a new mysqli::bind_value method (no replies)

Bob Weinand — Sun, 05 May 2013 16:00:01 +0200

I propose to add, contrary to the mysqli::bind_param method which accepts parameters only by ref (and triggers a fatal error when passing non-ref variables or values), a mysqli::bind_value method which accepts the variables by value.

There are a few problems when using bind_param which bind_value tries to solve:

a) When you aren't binding in a small scope, you have to make attention to not reusing the variable before execute()'ing the mysqli_stmt instance.
b) You have to pass values per reference, so that you cannot do for example in a function:
call_user_func_array([$stmt, "bind_param"], array_merge([str_repeat("s", func_num_args())], func_get_args()));
this would fail in a message you couldn't pass them by value (when you cannot write the function expecting references as variable for some reason). A workaround would be to array_walk the array and pass the variable by ref to a new array, which is not really handy.
c) When you try to pass raw values instead of a reference, it results in a "Fatal error: Cannot pass parameter 2 by reference".
d) Executing $stmt->bind_param("s", $a?$b:$c); would result in a "Strict Standards: Only variables should be passed by reference". Yeah, it's only a strict error, but I think it's best practice to code error free...

For c) and d): Yes, you could assign the result / raw value to a variable and then pass it to the function, but this are only a variable more, a code line more and a fraction of a nanosecond more (microoptimization, I just wanted to say it).

The PR for this request is at: https://github.com/php/php-src/pull/338

Bob

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Scalar Type Casting Magic Methods (7 replies)

Oleku Konko — Mon, 13 May 2013 10:20:03 +0200

Quick Observations :

I had this issue ( http://stackoverflow.com/questions/16375331/increment-on-tostring ) and it kept me thinking why no error was returned, then i stumble up this RFC : https://wiki.php.net/rfc/object_cast_to_types

The patch is basic , simple and working and it should be seriously considered in 5.5. I want to believe if https://github.com/php/php-src/pull/334 can make it to PHP 5.5 then we should give object_cast_to_types the same opportunity except they are string objections why it should not be so

Thanks
Oleku Konko

[PHP-DEV] Proposal: new implentation of JSON extension. (no replies)

Remi Collet — Sat, 04 May 2013 17:30:02 +0200

Raise again this discussion as no feedback on pecl ML.

Trying to solve https://bugs.php.net/bug.php?id=63520

I start to work on a dropin alternative for current json extension in php.

Current work:
https://github.com/remicollet/pecl-json-c

It is obviously to late for PHP 5.5, and need probably more feedback,
more tests, and more work before a RFC for PHP 5.6 (or later).

* json_encode : same code than php 5.5, no difference

* json_decode : wrapper over json-c 0.11 library.

Difference:
- error code returned by the parser are different (so only
PHP_JSON_ERROR_SYNTAX and PHP_JSON_ERROR_DEPTH are used)
- number only parse as integer (no automatic cast to double)
- loose of performance (but still acceptable, I think)

New feature: as json-c is an incremental parser, a new class is
available to allow incremental parsing (for large json encoded data)

Proposal:

1/ update existing pecl/json extension

- on pecl for older PHP 5.3 - 5.5
- on php-src in master / 5.6

OR

2/ new pecl/json-c extension

- PHP will keep the non free code

Should I open a RFC ?

Regards,
Remi.

P.S. I have tried to contact Omar, original author of this extension,
without any success.

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] [RFC] Add a second argument to callback of preg_replace_callback (no replies)

Laruence — Sat, 04 May 2013 16:00:01 +0200

Hey:
I thought it is a minor change, so was not plan to make a RFC ..

but since there are some insistent objections, I think a RFC is better.

let's people vote for it.

here is the RFC: https://wiki.php.net/rfc/second_arg_to_preg_callback

and objections are also listed.

thanks

--
Laruence Xinchen Hui
http://www.laruence.com/

[PHP-DEV] Multi-level Caching Fork of OPcache -- update (2 replies)

Terry Ellison — Wed, 08 May 2013 18:30:02 +0200

Please treat this email by way of request for feedback from the OPcache
developers and anyone interested in influencing my next steps on my
https://github.com/TerryE/opcache fork of OPcache and specifically on
the dev-filecache branch. The most appropriate channel is probably
https://github.com/TerryE/opcache/issues -- unless you think that the
comments have wider applicability for either the PECL or DEV communities.

My ultimate aim is to take this to a point where the OPcache developers
feel sufficiently comfortable to consider merging a future version back
into OPcache. I have added some detailed project wiki pages documenting
my scope and progress and in particular on
https://github.com/TerryE/opcache/wiki/MLC-OPcache-details and a brief
quote from the page:

> An indication of the potential performance benefits of OPcache CLI
> mode can be seen from a simple benchmark based on 100 executions of
> the MediaWiki runJobs.php maintenance batch script. This compiles some
> 44 PHP sources, comprising 45K lines and 1,312 Kbytes. The cached
> version reads a single runJobs.cache file of 1,013 Kbytes.
>
> Time in mSec Average Stdev
> Uncached Execution 179 7
> Cached Execution 77 7
> (Image Load Overhead) 18 3

In other words for this script, the MLC cache is delivering an
approximate 60% runtime saving. Of course this is only a point test,
and benefits will vary -- though I hope that switching to LZ4
compression will improve these figures further. But even this one point
challenges what seems to be a core PHP development dogma: "there's no
point in using a file cache, because it makes no material performance
difference". Even this build *does* deliver material benefits , and I
suggest that there is merit in moving to including MLC cached modes to
accelerate CLI and GCI SAPI modes using this or a similar approach.

From an internals -- rather than PECL -- viewpoint what this would mean
is that non-cached incremental compile-and-go execution modes would now
be the exception than the norm -- largely negating the disadvantages of
any compile-intensive optimization options.

So thank-you in anticipation for your feedback. I will do my utmost to
respond constructively to all comments. :-)
Regards Terry Ellison

PS. Apologies in advance: I am "up country" at my cottage on an Island
in the north Aegean with the nearest Wifi some walk away, so my Internet
access is limited at the moment, and I might take some time to respond.

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] A better error handling approach. (6 replies)

Adam Jon Richardson — Fri, 03 May 2013 08:40:06 +0200

PHP currently has two separate approaches to handling errors:
- Errors
- Exceptions

Both have their issues.

Using and responding to errors requires that the returned value (if
there is one) perform double duty as both a potential valid response
AND, in the case of error, a flag that something went wrong. It's easy
to forget to check that a particular call succeeded and specifically
handle the error. I find myself constantly revisiting the
documentation to ensure I know the specific error flag for functions,
and performing post-hoc analysis of error logs to make sure I didn't
miss an error flag that I would be better served by handling in the
standard flow of my app.

Using and responding to exceptions is a heavy-handed approach, as any
particular exception can bring the entire application down.
Additionally, the process of raising and catching exceptions loses
context of the error, often requiring many different subclasses of
exceptions to maintain the error state. Issues arise when the language
constructs for exceptions are liberally used in situations that are
not truly "exceptional," and where the the exception handling becomes
a glorified goto.

I've been programming in Go, and the ability to pass back multiple
arguments, one of which is conventionally the error state, is
wonderful. It's simple, clear, concise, and powerful. The code calling
into the error-capable function knows the context and can handle
errors appropriately according to the application requirements.

In PHP, we could provide the ability to automatically pack up a
comma-separated list of values as an array:

return $var1, $var2;
// returns [$var1, $var2];

And, we could provide the ability to automatically unpack an array
into separate variables:

$var1, $var2 = myFunction();
// same as list($var1, $var2) = myFunction();

This functionality would allow us to embrace the convention that an
error is passed back as one of the return values:

$dbh, $err = db\connect();
// check for error
if ($err) {
// handle db connection error
}
// carry on normally
$dbh->query("blah blah blah");

The simplicity (just passing back values), clarity (the code to handle
errors is proximal to the code that caused the error), and efficiency
(not having to create bunches of exception subclasses to maintain
context/information, and exceptions are expensive) of this approach is
a beautiful thing. You can see an explanation of Go error handling
here:
http://blog.golang.org/2011/07/error-handling-and-go.html

Concern 1: Isn't this just saving a few keystrokes?

Allowing developers to pass back an array and then access the members
of the array isn't the same thing, and we're not just saving a few
keystrokes if this is implemented. Providing this ability promotes
usage and clarity, and I'm confident Go would not have gotten
developers to follow this convention if the syntax didn't facilitate
the approach. I now write my Python code to handle errors in this same
manner, taking advantage of its ability to handle comma-separated
lists as tuples (something I didn't know about until recently, I must
confess):
http://stackoverflow.com/questions/423710/return-more-than-one-value-from-a-function-in-python

Concern 2: Why don't you just use Python or Go?

I really like using PHP for web development.

Concern 3: Are you saying we should get rid of errors and exceptions?

To be clear, errors have their place (maybe an extension failed to
load, or a warning about usage of undeclared vars, etc.), and so do
exceptions (for events that are truly "exceptional", that should cause
a major revision to the branching/flow of the application and/or stop
the application in its tracks if left unhandled.)

Adam

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php