Hi all, I encountered bug #40459 [1] recently. It seems the bug has been ignored because not many people encounter it and the original author did not give feedback. The issue is assigned to Wez. According to the git checkin history, he doesn't seem to be a contributor anymore. I mailed him to see if he can recommend someone to handle this issue, no response. So my question is: can anyone familiar with the Stream Wrapper code take a look at this issue? My C is not of sufficient level to fix this myself. My idea would be to abstract creating a stream wrapper instance and invoking the constructor to a separate function and calling that function from the various functions that use stream wrappers, as the amount of code needed to construct an instance and call the constructor seems quite high to copy everywhere. Kind regards, Jorrit Schippers [1] https://bugs.php.net/bug.php?id=40459 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php http://www.serverphorums.com/read.php?7,498679,498679#msg-498679 Wed, 19 Jun 2013 14:40:15 +0200 Phorum 5.2.18 http://www.serverphorums.com/read.php?7,498679,498857#msg-498857 http://www.serverphorums.com/read.php?7,498679,498857#msg-498857
On Fri, 2012-05-18 at 12:42 +0200, Jorrit Schippers - nCode wrote:
> So my question is: can anyone familiar with the Stream Wrapper code take
> a look at this issue? My C is not of sufficient level to fix this
> myself. My idea would be to abstract creating a stream wrapper instance
> and invoking the constructor to a separate function and calling that
> function from the various functions that use stream wrappers, as the
> amount of code needed to construct an instance and call the constructor
> seems quite high to copy everywhere.

"Fixing" this is quite trivial.. except that it breaks any code
depending on the current behavior where people are using the constructor
in a way which might have an bad impact. This could only be done in
master.

Sometime ago I stumbled over that behavior it and had an additional
issue preventing me from fixing it, which I don't remember right now ...

johannes



--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php]]> Johannes Schlüter php-internals Fri, 18 May 2012 18:00:02 +0200 http://www.serverphorums.com/read.php?7,498679,498679#msg-498679 http://www.serverphorums.com/read.php?7,498679,498679#msg-498679
I encountered bug #40459 [1] recently. It seems the bug has been ignored
because not many people encounter it and the original author did not
give feedback.

The issue is assigned to Wez. According to the git checkin history, he
doesn't seem to be a contributor anymore. I mailed him to see if he can
recommend someone to handle this issue, no response.

So my question is: can anyone familiar with the Stream Wrapper code take
a look at this issue? My C is not of sufficient level to fix this
myself. My idea would be to abstract creating a stream wrapper instance
and invoking the constructor to a separate function and calling that
function from the various functions that use stream wrappers, as the
amount of code needed to construct an instance and call the constructor
seems quite high to copy everywhere.


Kind regards,

Jorrit Schippers




[1] https://bugs.php.net/bug.php?id=40459

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php]]> Jorrit Schippers - nCode php-internals Fri, 18 May 2012 12:50:06 +0200