[PHP-DEV] Trouble with zend_language_parser.y

RE: [PHP-DEV] RE: Trouble with zend_language_parser.y

Clint Priest — Tue, 08 May 2012 01:10:02 +0200

That makes complete sense, it is indeed a LONG type that's getting to that point, thank you!

> -----Original Message-----
> From: Nikita Popov [mailto:nikita.ppv@googlemail.com]
> Sent: Monday, May 07, 2012 2:27 PM
> To: Clint Priest
> Cc: Etienne Kneuss; Felipe Pena (felipensp@gmail.com); internals@lists.php.net
> Subject: Re: [PHP-DEV] RE: Trouble with zend_language_parser.y
>
> On Mon, May 7, 2012 at 9:16 PM, Clint Priest wrote:
> > Alright, I'm new to git but I believe I have a branch off my fork which demonstrates the issue.
> >
> > https://github.com/cpriest/php-src/tree/isset-unset-issue
> >
> > This branch also features just code necessary to produce the results, if you search in zend_compile.h for ISSUE-ISSET-LANGUAGE-
> PARSER you'll see further contextual notes on what I'm seeing that's the issue.
> >
> > It seems the function_token is getting the rest of the script stuffed into it.
> When you write $1 (where 1 references a terminal) you are accessing the zendlval of the token. Not all tokens define an lval. Only
> tokens which have a meaningful value (like numbers, strings, etc). So when accessing the value of T_ISSET you just get some junk (as
> it does not set a value).
>
> Not sure that's really right, but that would be my guess :)
>
> Nikita

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] RE: Trouble with zend_language_parser.y

Nikita Popov — Mon, 07 May 2012 21:30:02 +0200

On Mon, May 7, 2012 at 9:16 PM, Clint Priest wrote:
> Alright, I'm new to git but I believe I have a branch off my fork which demonstrates the issue.
>
> https://github.com/cpriest/php-src/tree/isset-unset-issue
>
> This branch also features just code necessary to produce the results, if you search in zend_compile.h for ISSUE-ISSET-LANGUAGE-PARSER you'll see further contextual notes on what I'm seeing that's the issue.
>
> It seems the function_token is getting the rest of the script stuffed into it.
When you write $1 (where 1 references a terminal) you are accessing
the zendlval of the token. Not all tokens define an lval. Only tokens
which have a meaningful value (like numbers, strings, etc). So when
accessing the value of T_ISSET you just get some junk (as it does not
set a value).

Not sure that's really right, but that would be my guess :)

Nikita

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] RE: Trouble with zend_language_parser.y

Clint Priest — Mon, 07 May 2012 21:20:03 +0200

Alright, I'm new to git but I believe I have a branch off my fork which demonstrates the issue.

https://github.com/cpriest/php-src/tree/isset-unset-issue

This branch also features just code necessary to produce the results, if you search in zend_compile.h for ISSUE-ISSET-LANGUAGE-PARSER you'll see further contextual notes on what I'm seeing that's the issue.

It seems the function_token is getting the rest of the script stuffed into it.

> -----Original Message-----
> From: ekneuss@gmail.com [mailto:ekneuss@gmail.com] On Behalf Of Etienne Kneuss
> Sent: Saturday, May 05, 2012 10:07 AM
> To: Clint Priest
> Cc: internals@lists.php.net
> Subject: Re: [PHP-DEV] RE: Trouble with zend_language_parser.y
>
> Hi Clint,
>
> On Wed, May 2, 2012 at 3:23 PM, Clint Priest wrote:
> > Anyone have any help with this?
>
> hard to say like this with this partial patch, do you have some git branch I can pull from to reproduce and analyze this?
> Alternatively, the complete an up-to-date patch?
>
> Best Regards,

RE: [PHP-DEV] Trouble with zend_language_parser.y

Clint Priest — Mon, 07 May 2012 15:50:02 +0200

This has been changed to the more traditional way.

I've moved on and am using _isset and _unset for the moment, but I'll clone my branch with what I need to accomplish and post it here tonight.

-----Original Message-----
From: Felipe Pena [mailto:felipensp@gmail.com]
Sent: Saturday, May 05, 2012 10:19 AM
To: Clint Priest
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] Trouble with zend_language_parser.y

Hi,

2012/4/26 Clint Priest :
> I'm having some trouble setting up the re2c to allow the isset/unset. Here are the definitions, I've added the two T_ISSET statements:
>
> ------------------------------------------------------------
> accessors:
> accessor_function
> accessor_function
> accessor_function
> accessor_function
> | accessor_function
> accessor_function
> accessor_function
> | accessor_function
> accessor_function
> | accessor_function
> | /* Empty */
> ;
>

This rule is weird too, do you want a limited number of accessor?

--
Regards,
Felipe Pena

Re: [PHP-DEV] Trouble with zend_language_parser.y

Felipe Pena — Sat, 05 May 2012 17:20:02 +0200

Hi,

2012/4/26 Clint Priest :
> I'm having some trouble setting up the re2c to allow the isset/unset. Here are the definitions, I've added the two T_ISSET statements:
>
> ------------------------------------------------------------
> accessors:
> accessor_function
> accessor_function
> accessor_function
> accessor_function
> | accessor_function
> accessor_function
> accessor_function
> | accessor_function
> accessor_function
> | accessor_function
> | /* Empty */
> ;
>

This rule is weird too, do you want a limited number of accessor?

--
Regards,
Felipe Pena

Re: [PHP-DEV] RE: Trouble with zend_language_parser.y

Etienne Kneuss — Sat, 05 May 2012 17:10:04 +0200

Hi Clint,

On Wed, May 2, 2012 at 3:23 PM, Clint Priest wrote:
> Anyone have any help with this?

hard to say like this with this partial patch, do you have some git
branch I can pull from to reproduce and analyze this?
Alternatively, the complete an up-to-date patch?

Best Regards,

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] RE: Trouble with zend_language_parser.y

Clint Priest — Wed, 02 May 2012 15:30:02 +0200

Anyone have any help with this?

$1 of the first T_ISSET is matching against "\n\t\tisset {..." (... being the rest of the set body through to the end of the script.

-----Original Message-----
From: Clint Priest [mailto:cpriest@zerocue.com]
Sent: Wednesday, April 25, 2012 10:41 PM
To: internals@lists.php.net
Subject: [PHP-DEV] Trouble with zend_language_parser.y

I'm having some trouble setting up the re2c to allow the isset/unset. Here are the definitions, I've added the two T_ISSET statements:

------------------------------------------------------------
accessors:
accessor_function
accessor_function
accessor_function
accessor_function
| accessor_function
accessor_function
accessor_function
| accessor_function
accessor_function
| accessor_function
| /* Empty */
;

accessor_modifiers:
/* empty */ { Z_LVAL($$.u.constant) = CG(access_type); }
| non_empty_accessor_modifiers { $$ = $1; }
;

non_empty_accessor_modifiers:
accessor_modifier { $$ = $1; }
| non_empty_accessor_modifiers accessor_modifier { Z_LVAL($$.u.constant) = zend_do_verify_access_types(&$1, &$2); }

accessor_modifier:
T_PUBLIC { Z_LVAL($$.u.constant) = ZEND_ACC_PUBLIC; }
| T_PROTECTED { Z_LVAL($$.u.constant) = ZEND_ACC_PROTECTED; }
| T_PRIVATE { Z_LVAL($$.u.constant) = ZEND_ACC_PRIVATE; }
| T_STATIC { Z_LVAL($$.u.constant) = ZEND_ACC_STATIC; }
| T_FINAL { Z_LVAL($$.u.constant) = ZEND_ACC_FINAL; }
;

accessor_function:
T_ISSET
{ Z_LVAL($$.u.constant) = ZEND_ACC_PUBLIC; zend_do_begin_accessor_declaration(&$1, CG(accessor_node), &$$, 0 TSRMLS_CC); }
'{' inner_statement_list '}'
{ zend_do_end_accessor_declaration(&$1, CG(accessor_node), &$$, &$3 TSRMLS_CC); }
| T_ISSET
{ Z_LVAL($$.u.constant) = ZEND_ACC_PUBLIC;
zend_do_begin_accessor_declaration(&$1, CG(accessor_node), &$$, 0 TSRMLS_CC);
zend_do_end_accessor_declaration(&$1, CG(accessor_node), &$$, NULL TSRMLS_CC);
}
';'
| accessor_modifiers is_reference T_STRING
{ zend_do_begin_accessor_declaration(&$3, CG(accessor_node), &$1, $2.op_type TSRMLS_CC); }
'{' inner_statement_list '}'
{ zend_do_end_accessor_declaration(&$3, CG(accessor_node), &$1, &$5 TSRMLS_CC); }
| accessor_modifiers is_reference T_STRING
{
zend_do_begin_accessor_declaration(&$3, CG(accessor_node), &$1, $2.op_type TSRMLS_CC);
zend_do_end_accessor_declaration(&$3, CG(accessor_node), &$1, NULL TSRMLS_CC);
}
';'
;------------------------------------------------------------

Here is the PHP it's trying to parse:

public $Hours {
get {
echo "Getting Hours\r\n";
return $this->Seconds / 3600;
}
set { // The variable $value holds the incoming value to be "set"
echo "Setting Hours to {$value}\r\n";
$this->Seconds = $value * 3600;
}
isset { return $this->Seconds != NULL; }
unset { $this->Seconds = NULL; }
}

$1 of the first T_ISSET is matching against "\n\t\tisset {..." (... being the rest of the set body through to the end of the script.

What's going on here?

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Trouble with zend_language_parser.y

Clint Priest — Thu, 26 Apr 2012 05:50:02 +0200

I'm having some trouble setting up the re2c to allow the isset/unset. Here are the definitions, I've added the two T_ISSET statements:

------------------------------------------------------------
accessors:
accessor_function
accessor_function
accessor_function
accessor_function
| accessor_function
accessor_function
accessor_function
| accessor_function
accessor_function
| accessor_function
| /* Empty */
;

accessor_modifiers:
/* empty */ { Z_LVAL($$.u.constant) = CG(access_type); }
| non_empty_accessor_modifiers { $$ = $1; }
;

non_empty_accessor_modifiers:
accessor_modifier { $$ = $1; }
| non_empty_accessor_modifiers accessor_modifier { Z_LVAL($$.u.constant) = zend_do_verify_access_types(&$1, &$2); }

accessor_modifier:
T_PUBLIC { Z_LVAL($$.u.constant) = ZEND_ACC_PUBLIC; }
| T_PROTECTED { Z_LVAL($$.u.constant) = ZEND_ACC_PROTECTED; }
| T_PRIVATE { Z_LVAL($$.u.constant) = ZEND_ACC_PRIVATE; }
| T_STATIC { Z_LVAL($$.u.constant) = ZEND_ACC_STATIC; }
| T_FINAL { Z_LVAL($$.u.constant) = ZEND_ACC_FINAL; }
;

accessor_function:
T_ISSET
{ Z_LVAL($$.u.constant) = ZEND_ACC_PUBLIC; zend_do_begin_accessor_declaration(&$1, CG(accessor_node), &$$, 0 TSRMLS_CC); }
'{' inner_statement_list '}'
{ zend_do_end_accessor_declaration(&$1, CG(accessor_node), &$$, &$3 TSRMLS_CC); }
| T_ISSET
{ Z_LVAL($$.u.constant) = ZEND_ACC_PUBLIC;
zend_do_begin_accessor_declaration(&$1, CG(accessor_node), &$$, 0 TSRMLS_CC);
zend_do_end_accessor_declaration(&$1, CG(accessor_node), &$$, NULL TSRMLS_CC);
}
';'
| accessor_modifiers is_reference T_STRING
{ zend_do_begin_accessor_declaration(&$3, CG(accessor_node), &$1, $2.op_type TSRMLS_CC); }
'{' inner_statement_list '}'
{ zend_do_end_accessor_declaration(&$3, CG(accessor_node), &$1, &$5 TSRMLS_CC); }
| accessor_modifiers is_reference T_STRING
{
zend_do_begin_accessor_declaration(&$3, CG(accessor_node), &$1, $2.op_type TSRMLS_CC);
zend_do_end_accessor_declaration(&$3, CG(accessor_node), &$1, NULL TSRMLS_CC);
}
';'
;------------------------------------------------------------

Here is the PHP it's trying to parse:

public $Hours {
get {
echo "Getting Hours\r\n";
return $this->Seconds / 3600;
}
set { // The variable $value holds the incoming value to be "set"
echo "Setting Hours to {$value}\r\n";
$this->Seconds = $value * 3600;
}
isset { return $this->Seconds != NULL; }
unset { $this->Seconds = NULL; }
}

$1 of the first T_ISSET is matching against "\n\t\tisset {..." (... being the rest of the set body through to the end of the script.

What's going on here?